From owner-freebsd-net@FreeBSD.ORG Thu Jun 10 19:20:38 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7E5C91065672 for ; Thu, 10 Jun 2010 19:20:38 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-pz0-f175.google.com (mail-pz0-f175.google.com [209.85.222.175]) by mx1.freebsd.org (Postfix) with ESMTP id 56FFC8FC14 for ; Thu, 10 Jun 2010 19:20:38 +0000 (UTC) Received: by pzk5 with SMTP id 5so152341pzk.14 for ; Thu, 10 Jun 2010 12:20:38 -0700 (PDT) Received: by 10.114.10.14 with SMTP id 14mr530021waj.72.1276197637912; Thu, 10 Jun 2010 12:20:37 -0700 (PDT) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.114.241.2 with HTTP; Thu, 10 Jun 2010 12:20:17 -0700 (PDT) In-Reply-To: References: From: Juli Mallett Date: Thu, 10 Jun 2010 12:20:17 -0700 X-Google-Sender-Auth: pKs71sLnpR7Z9tpoSi4V0HhZNLQ Message-ID: To: Alexander Sack Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-net@freebsd.org, Jack Vogel Subject: Re: Dual-rate transceivers with ixgbe? X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2010 19:20:38 -0000 On Thu, Jun 10, 2010 at 12:04, Alexander Sack wrote: > However, would it be possible to please make this a kenv tunable in > the driver? =A0Its kinda stupid I have to recompile to add a SFP. =A0It > can certainly be an unsupported feature by you. This is a good idea, but asking Jack to commit something that goes against Intel's wishes and which he's not going to support is probably a losing strategy. Whether he minds someone else committing might be another story :) One thing that the base driver probably ought to do is not fail in attach if there's an unrecognized SFP+ module. Since we get interrupts on module change (although this doesn't seem to always work *entirely* right in the stock sources, mostly wrt stored values of AUTOC and the like) it should be possible to bring the interface up with the unsupported (and disabled) SFP+ module and do the SFP+ module probing we already do on hot-swap. > Patch attached. =A0Tested with CURRENT driver on a 7.2-amd64-release > machine. =A0If you set the tunable to 1, ixgbe loads without issue. =A0If > you leave it to zero (default), it will not attach to unsupported > SFPs. If you're going to do this, you ought to support SFP as well as SFP+ modules which requires a few more changes. But not very many :) Although some SFP modules seem to return something for the comp_codes_10g read, which makes deciding which SFI mode to configure non-trivial, short of providing an actual vendor/model switch. Thanks, Juli.