From owner-svn-src-head@freebsd.org Sat Sep 26 14:20:32 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1A6B0A097F6; Sat, 26 Sep 2015 14:20:32 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id F2DE91E5; Sat, 26 Sep 2015 14:20:31 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id EA17915A6; Sat, 26 Sep 2015 14:20:31 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 977CD13D85; Sat, 26 Sep 2015 14:20:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id t-lo_u_IOfdG; Sat, 26 Sep 2015 14:20:28 +0000 (UTC) Subject: Re: svn commit: r288241 - head/share/mk DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 3168A13D7E To: Warner Losh , NGie Cooper References: <201509252303.t8PN3Wx0098623@repo.freebsd.org> <5605D4FC.4040205@FreeBSD.org> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <5606A9AE.7070303@FreeBSD.org> Date: Sat, 26 Sep 2015 07:20:30 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HxQWc8vLEbDvddpgC5HjS6Xo5bHfrWtt3" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Sep 2015 14:20:32 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HxQWc8vLEbDvddpgC5HjS6Xo5bHfrWtt3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 9/26/2015 7:19 AM, Warner Losh wrote: >=20 >=20 > On Fri, Sep 25, 2015 at 11:11 PM, NGie Cooper > wrote: >=20 > On Fri, Sep 25, 2015 at 4:13 PM, Bryan Drewery > wrote: > > On 9/25/2015 4:12 PM, NGie Cooper wrote: > >> On Fri, Sep 25, 2015 at 4:03 PM, Bryan Drewery > wrote: > >>> Author: bdrewery > >>> Date: Fri Sep 25 23:03:32 2015 > >>> New Revision: 288241 > >>> URL: https://svnweb.freebsd.org/changeset/base/288241 > >>> > >>> Log: > >>> Remove 'set -e' that are no longer needed as it is already de= fault. > >>> > >>> When bmake was initially imported at r241298 shell commands w= ere no longer > >>> ran with 'set -e' as they were before. This was fixed in r25= 4980 so they > >>> again always use 'set -e'. > >> > >> The bsd.subdir.mk portion of the change l= ooks > like it would cause > >> issues depending on what's being called (fmake or an earlier ver= sion > >> of sys.mk might be used at install time). > >> > > > > We only support bmake in head. And the 'set -e' were only added f= or > > bmake compatibility before it was fixed to work like fmake did. >=20 > Sorry. Fuzzy memory on the latter item. Yeah, I requested it a > couple years ago. >=20 > We might only support bmake in head, but there's nothing preventing= > someone from doing a source upgrade from one of the older 10 releas= es > to 11+. Thinking about this a bit more, this is an extreme edge cas= e > that doesn't really matter, because people doing source upgrades > across major releases really should be doing them from the latest > minor release for the major release >=20 >=20 > I wouldn't state it so glibly. It is not as extreme as you might think.= > For a > long time compiling -current from a host that was one or two major > releases old has worked. Currently we advertise that we can upgrade > from the stable/9 branch point or newer to tip of head (based on values= > in Makefile.inc1). >=20 > I don't believe that Bryan's change set changes that in any significant= way, > but given the large amount of churn he and I (and others) have generate= d in > /usr/share/mk, testing from a 9.x machine would be prudent. I didn't re= move > some minor bits of code, and also made sys.mk compatibl= e > with the FreeBSD 9 > fmake because of issues like this. >=20 Note that fmake compatibility was explicitly removed around the META_MODE import time. fmake doesn't work at all currently. --=20 Regards, Bryan Drewery --HxQWc8vLEbDvddpgC5HjS6Xo5bHfrWtt3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWBqmuAAoJEDXXcbtuRpfPahEIAKuaVYbsMIkCH/tGxMsVYlNJ r5RJpgLdok0xgowulBWghajiusle4zkfvbSbeZu68DYAruujLu/py2adNA828O4o +A0UFxy+ng81vpkPF+RyoK+c15r486xdsW3LkaMZIbSJgDI75M8AP63JE1xai1WV FqwRqyTAzogc3gJ4FalatFkYQJ1OcQqRaPeeUDM59mV1Ktso6NCj+V49R3eFfwIv tew5Dgdkmlwx2pkC+YiV1y06OhJUSg7+AfAjActXf43tDY8PFhEMPWZMx0GW5nLx 6yb9u28v7IiJmOSXLDx2pWuDBGqg/ioWLEDL6Xoq8xjMhtNuFR+h8r3knJqcZhE= =q3Ic -----END PGP SIGNATURE----- --HxQWc8vLEbDvddpgC5HjS6Xo5bHfrWtt3--