From owner-p4-projects@FreeBSD.ORG  Sun Jun 13 20:31:14 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9546F16A4D1; Sun, 13 Jun 2004 20:31:14 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4F92B16A4CE
	for <perforce@freebsd.org>; Sun, 13 Jun 2004 20:31:14 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0E8F343D53
	for <perforce@freebsd.org>; Sun, 13 Jun 2004 20:31:14 +0000 (GMT)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5DKUPL5045735
	for <perforce@freebsd.org>; Sun, 13 Jun 2004 20:30:25 GMT
	(envelope-from marcel@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5DKUPxG045732
	for perforce@freebsd.org; Sun, 13 Jun 2004 20:30:25 GMT
	(envelope-from marcel@freebsd.org)
Date: Sun, 13 Jun 2004 20:30:25 GMT
Message-Id: <200406132030.i5DKUPxG045732@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	marcel@freebsd.org using -f
From: Marcel Moolenaar <marcel@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 54855 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Jun 2004 20:31:15 -0000

http://perforce.freebsd.org/chv.cgi?CH=54855

Change 54855 by marcel@marcel_nfs on 2004/06/13 20:29:36

	The variable access functions are supposed to return 1 on
	success and 0 only on failure. Fix them.

Affected files ...

.. //depot/projects/gdb/sys/i386/i386/db_trace.c#9 edit

Differences ...

==== //depot/projects/gdb/sys/i386/i386/db_trace.c#9 (text+ko) ====

@@ -101,7 +101,7 @@
 		*valuep = r ## reg ();	\
 	else				\
 		load_ ## reg (*valuep); \
-	return (0);			\
+	return (1);			\
 }
 
 DB_DRX_FUNC(dr0)
@@ -125,32 +125,43 @@
 {
 	int *reg;
 
+	if (kdb_frame == NULL)
+		return (0);
+
 	reg = (int *)((uintptr_t)kdb_frame + (db_expr_t)vp->valuep);
 	if (op == DB_VAR_GET)
 		*valuep = *reg;
 	else
 		*reg = *valuep;
-	return (0);
+	return (1);
 }
 
 static int
 db_esp(struct db_variable *vp, db_expr_t *valuep, int op)
 {
+
+	if (kdb_frame == NULL)
+		return (0);
+
 	if (op == DB_VAR_GET)
 		*valuep = get_esp(kdb_frame);
 	else if (ISPL(kdb_frame->tf_cs))
 		kdb_frame->tf_esp = *valuep;
-	return (0);
+	return (1);
 }
 
 static int
 db_ss(struct db_variable *vp, db_expr_t *valuep, int op)
 {
+
+	if (kdb_frame == NULL)
+		return (0);
+
 	if (op == DB_VAR_GET)
 		*valuep = (ISPL(kdb_frame->tf_cs)) ? kdb_frame->tf_ss : rss();
 	else if (ISPL(kdb_frame->tf_cs))
 		kdb_frame->tf_ss = *valuep;
-	return (0);
+	return (1);
 }
 
 /*