From owner-svn-ports-all@freebsd.org  Tue Nov 13 12:26:51 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A1CD1123B05;
 Tue, 13 Nov 2018 12:26:51 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id ADFD2825C9;
 Tue, 13 Nov 2018 12:26:50 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 9DEF4167CC; Tue, 13 Nov 2018 12:26:50 +0000 (UTC)
Date: Tue, 13 Nov 2018 12:26:50 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Jan Beich <jbeich@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r484868 - head/graphics/azpainter
Message-ID: <20181113122650.GA42216@FreeBSD.org>
References: <201811131020.wADAKkDd074298@repo.freebsd.org>
 <36s5-fa3k-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <36s5-fa3k-wny@FreeBSD.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: ADFD2825C9
X-Spamd-Result: default: False [-103.10 / 200.00]; ARC_NA(0.00)[];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 ALLOW_DOMAIN_WHITELIST(-100.00)[freebsd.org];
 FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4];
 TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];
 MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; R_SPF_SOFTFAIL(0.00)[~all];
 MX_GOOD(-0.01)[cached: mx66.freebsd.org];
 NEURAL_HAM_SHORT(-0.99)[-0.995,0]; FROM_EQ_ENVFROM(0.00)[];
 R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[];
 RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]
X-Rspamd-Server: mx1.freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Nov 2018 12:26:51 -0000

On Tue, Nov 13, 2018 at 01:14:23PM +0100, Jan Beich wrote:
> Alexey Dokuchaev <danfe@FreeBSD.org> writes:
> > New Revision: 484868
> > URL: https://svnweb.freebsd.org/changeset/ports/484868
> >
> > Log:
> >   Try to unbreak the build on architectures that still use old GCC as their
> >   system compiler by using contemporary GCC version.
> >   
> >   Tested on:	powerpc
> [...]
> > +.include <bsd.port.pre.mk>
> 
> ARCH is defined in bsd.port.options.mk, so pre/post.mk could've been
> avoided.

I'll look into it, thanks.

> > +.if ${ARCH:Mpowerpc*} || ${ARCH} == sparc64
> > +USE_GCC=	yes
> > +.endif
> 
> Why not USES=compiler:c++11-lang? mips* and riscv64 are also GCC-only atm.

Because seeing "c++11-lang" in pure C program is confusing?  I don't know
much knowledge about those arches so I didn't include them.  It would be
nice to specify "GCC-4.2.1 does not cut it" without having to spell C++11.

./danfe