From owner-p4-projects Mon Aug 19 10:17:34 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id CB69537B401; Mon, 19 Aug 2002 10:17:26 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 62EDD37B400; Mon, 19 Aug 2002 10:17:26 -0700 (PDT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 22C9D43E75; Mon, 19 Aug 2002 10:17:25 -0700 (PDT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.12.4/8.12.4) with SMTP id g7JHHAOo016723; Mon, 19 Aug 2002 13:17:10 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Mon, 19 Aug 2002 13:17:10 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Brian Feldman Cc: Perforce Change Reviews Subject: Re: PERFORCE change 16271 for review In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Although I have to admit it makes one wonder if we shouldn't be considering an API model more like chown/fchown/lchown... Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories On Mon, 19 Aug 2002, Robert Watson wrote: > Feel free to merge that to the main tree, btw. It might also be worth > dropping a note in appropriate man pages. > > Robert N M Watson FreeBSD Core Team, TrustedBSD Projects > robert@fledge.watson.org Network Associates Laboratories > > On Mon, 19 Aug 2002, Brian Feldman wrote: > > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=16271 > > > > Change 16271 by green@green_laptop_2 on 2002/08/19 07:43:34 > > > > Make extattr set/get calls operate on symlinks, not their > > targets. > > > > Affected files ... > > > > .. //depot/projects/trustedbsd/mac/sys/kern/vfs_syscalls.c#79 edit > > > > Differences ... > > > > ==== //depot/projects/trustedbsd/mac/sys/kern/vfs_syscalls.c#79 (text+ko) ==== > > > > @@ -3777,7 +3777,7 @@ > > if (error) > > return (error); > > > > - NDINIT(&nd, LOOKUP, FOLLOW, UIO_USERSPACE, uap->path, td); > > + NDINIT(&nd, LOOKUP, NOFOLLOW, UIO_USERSPACE, uap->path, td); > > if ((error = namei(&nd)) != 0) > > return (error); > > NDFREE(&nd, NDF_ONLY_PNBUF); > > @@ -3907,7 +3907,7 @@ > > if (error) > > return (error); > > > > - NDINIT(&nd, LOOKUP, FOLLOW, UIO_USERSPACE, uap->path, td); > > + NDINIT(&nd, LOOKUP, NOFOLLOW, UIO_USERSPACE, uap->path, td); > > if ((error = namei(&nd)) != 0) > > return (error); > > NDFREE(&nd, NDF_ONLY_PNBUF); > > @@ -4000,7 +4000,7 @@ > > if (error) > > return(error); > > > > - NDINIT(&nd, LOOKUP, FOLLOW, UIO_USERSPACE, uap->path, td); > > + NDINIT(&nd, LOOKUP, NOFOLLOW, UIO_USERSPACE, uap->path, td); > > if ((error = namei(&nd)) != 0) > > return(error); > > NDFREE(&nd, NDF_ONLY_PNBUF); > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message