Date: Fri, 28 Dec 2007 20:51:06 GMT From: Josh Carroll <josh.carroll@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/119120: Request to update devel/upnp to 1.6.3 which compiles properly on 7.x amd64 Message-ID: <200712282051.lBSKp6Gi030974@www.freebsd.org> Resent-Message-ID: <200712282100.lBSL051l065217@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 119120
>Category: ports
>Synopsis: Request to update devel/upnp to 1.6.3 which compiles properly on 7.x amd64
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Dec 28 21:00:05 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator: Josh Carroll
>Release: 7.0-RC1
>Organization:
n/a
>Environment:
FreeBSD pflog.net 7.0-RC1 FreeBSD 7.0-RC1 #0: Sun Dec 23 21:03:36 EST 2007 root@pflog.net:/usr/obj/usr/src/sys/PFLOG amd64
>Description:
The 1.6.0 release of the devel/upnp port does not compile properly on the amd64 release of 7.x, due to the use of ftime(3) which requires libcompat. This won't compile due to a relocation error.
I submitted a patch to the upstream source, which has been included in the 1.6.3 release of libupnp, which uses gettimeofday(2) instead of ftime. This release compiles properly on amd64/RELENG_7_0 and works properly.
I would like to request the devel/upnp port be bumped to the 1.6.3 release.
Attached is a patch against the existing upnp port to bring it up to 1.6.3, including some minor changes to pkg-plist.
Thanks!
Josh
>How-To-Repeat:
n/a
>Fix:
Patch attached.
Patch attached with submission follows:
diff -urN upnp/Makefile upnp.new/Makefile
--- upnp/Makefile 2007-10-24 23:25:52.000000000 -0400
+++ upnp.new/Makefile 2007-12-28 15:38:52.000000000 -0500
@@ -6,8 +6,7 @@
#
PORTNAME= upnp
-PORTVERSION= 1.6.0
-PORTEPOCH= 1
+PORTVERSION= 1.6.3
CATEGORIES= devel
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE}
MASTER_SITE_SUBDIR= pupnp
@@ -25,14 +24,8 @@
.include <bsd.port.pre.mk>
-.if ${OSVERSION} >= 700042
-.if ${ARCH} == "amd64" || ${ARCH} == "sparc64"
-BROKEN= Does not compile with GCC 4.2
-.endif
-.endif
-
MAKE_ENV= PTHREAD_LIBS=${PTHREAD_LIBS}
-CONFIGURE_ENV+= LIBS="-llwres -lcompat"
+CONFIGURE_ENV+= LIBS="-llwres"
.if defined(NOPORTDOCS)
CONFIGURE_ARGS= --without-documentation
diff -urN upnp/distinfo upnp.new/distinfo
--- upnp/distinfo 2007-07-09 09:04:35.000000000 -0400
+++ upnp.new/distinfo 2007-12-28 15:36:16.000000000 -0500
@@ -1,3 +1,4 @@
-MD5 (libupnp-1.6.0.tar.bz2) = 3185b3fd9d7e8f5a3d29314e8d369c66
-SHA256 (libupnp-1.6.0.tar.bz2) = 447ef98ebdb42847b88acc7b222d36e1caeb6ead87f8f1821ed7a8dffb3c5114
-SIZE (libupnp-1.6.0.tar.bz2) = 1135997
+MD5 (libupnp-1.6.3.tar.bz2) = 553f3491fe4da88aba1763497730e2c0
+SHA256 (libupnp-1.6.3.tar.bz2) = 79b76de19f67b4dc4c420c9200e7b2dd4c6e0916a3637f6aad21e035fa89cf3a
+SIZE (libupnp-1.6.3.tar.bz2) = 1136813
+
diff -urN upnp/pkg-plist upnp.new/pkg-plist
--- upnp/pkg-plist 2007-07-09 09:04:35.000000000 -0400
+++ upnp.new/pkg-plist 2007-12-28 15:40:31.000000000 -0500
@@ -2,7 +2,6 @@
include/upnp/LinkedList.h
include/upnp/ThreadPool.h
include/upnp/TimerThread.h
-include/upnp/iasnprintf.h
include/upnp/ithread.h
include/upnp/ixml.h
include/upnp/upnp.h
@@ -16,7 +15,7 @@
lib/libthreadutil.a
lib/libthreadutil.la
lib/libthreadutil.so
-lib/libthreadutil.so.3
+lib/libthreadutil.so.4
lib/libupnp.a
lib/libupnp.la
lib/libupnp.so
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712282051.lBSKp6Gi030974>