Date: Tue, 24 Mar 2015 19:37:36 +0100 From: John Marino <freebsd.contact@marino.st> To: John Marino <marino@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r382100 - in head: archivers/pixz archivers/pixz/files dns/dualserver french/aster japanese/scim-skk news/nzbget ports-mgmt/bpm sysutils/freeipmi x11-wm/libcompizconfig Message-ID: <5511AEF0.4010304@marino.st> In-Reply-To: <20150324183132.GD11473@graf.pompo.net> References: <201503241351.t2ODpIjS082125@svn.freebsd.org> <20150324183132.GD11473@graf.pompo.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/24/2015 19:31, Thierry Thomas wrote:
>> Modified: head/french/aster/Makefile
>> ==============================================================================
>> --- head/french/aster/Makefile Tue Mar 24 13:43:16 2015 (r382099)
>> +++ head/french/aster/Makefile Tue Mar 24 13:51:17 2015 (r382100)
>> @@ -252,9 +252,9 @@ pre-configure:
>> ${ECHO_CMD} "F90='${FC}'" >> ${WRKSRC}/setup.cfg
>> ${ECHO_CMD} "MATHLIB='${lib_math} ${LDFLAGS} -lgfortran -lm -lkvm'" \
>> >> ${WRKSRC}/setup.cfg
>> - ${ECHO_CMD} "OTHERLIB='-Xlinker -export-dynamic -lutil ${PTHREAD_LIBS} -lz'" \
>> + ${ECHO_CMD} "OTHERLIB='-Xlinker -export-dynamic -lutil -lpthread -lz'" \
>
> I agree with you when you remove lines or patches such as
>
> s/-lpthread/${PTHREAD_LIBS}/
>
> but I disagree with your changes here: it's better to add
> ${PTHREAD_LIBS} than -lpthread.
>
The blanket task is to remove ${PTHREAD_LIBS}. We are going to remove
it from ports entirely. And it only has one possible value (defined in
bsd.port.mk, so it's safe to replace with either -pthread or -lpthread
(the latter is preferred now).
John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5511AEF0.4010304>