Date: Wed, 20 Feb 2019 17:37:58 +1100 From: Kubilay Kocak <koobs@FreeBSD.org> To: Tobias Kortkamp <tobik@freebsd.org>, Cy Schubert <cy@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Joe Marcus Clarke <marcus@freebsd.org> Subject: Re: svn commit: r493407 - head/graphics/xpdf4 Message-ID: <4a641dc1-0337-00ee-55a2-80cb56263c27@FreeBSD.org> In-Reply-To: <20190220063422.GA18880@urd.tobik.me> References: <201902200614.x1K6Ev15089326@repo.freebsd.org> <20190220063422.GA18880@urd.tobik.me>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20/02/2019 5:34 pm, Tobias Kortkamp wrote: > On Wed, Feb 20, 2019 at 06:14:57AM +0000, Cy Schubert wrote: >> Author: cy >> Date: Wed Feb 20 06:14:57 2019 >> New Revision: 493407 >> URL: https://svnweb.freebsd.org/changeset/ports/493407 >> >> Log: >> Remove whitespace in USE_QT, otherwise qmake_build is ignored. >> >> Reported by: Paul Beard <paulbeard@gmail.com> >> >> Modified: >> head/graphics/xpdf4/Makefile >> >> Modified: head/graphics/xpdf4/Makefile >> ============================================================================== >> --- head/graphics/xpdf4/Makefile Wed Feb 20 04:50:53 2019 (r493406) >> +++ head/graphics/xpdf4/Makefile Wed Feb 20 06:14:57 2019 (r493407) >> @@ -27,8 +27,7 @@ SUB_FILES= xpdf-man.conf >> >> USES= compiler:c++11-lang cmake localbase:ldflags \ >> desktop-file-utils qt:5 >> -USE_QT= buildtools_build,concurrent,core,gui,network,printsupport,\ >> - qmake_build,svg,widgets >> +USE_QT= buildtools_build,concurrent,core,gui,network,printsupport,qmake_build,svg,widgets > > Next step: Replace the , with spaces to actually add Qt dependencies > to the port. Check with build-depends-list, run-depends-list, > stage-qa. Currently the port has no Qt 5 dependencies and it fails > to build in Poudriere: > > ===> Checking for items in pkg-plist which are not in STAGEDIR > Error: Missing: libexec/xpdf/xpdf > Error: Missing: %%DATADIR%%/man/man1/xpdf.1.gz > ===> Error: Plist issues found. > If USE_* values are never comma-separated (always space separated), sounds like a good portlint check to have. If we have some comma-separated support framework bits (I didn't check), maybe we should standardize on not doing so
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4a641dc1-0337-00ee-55a2-80cb56263c27>