From nobody Fri Jun 27 20:19:44 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bTRjy6GDLz60Cd9; Fri, 27 Jun 2025 20:19:50 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bTRjy3ySbz3Kql; Fri, 27 Jun 2025 20:19:50 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-x72c.google.com with SMTP id af79cd13be357-7d3862646eeso13169185a.2; Fri, 27 Jun 2025 13:19:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751055588; x=1751660388; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=pXVRSgb2FwoGmCqMjR70aPhAiVZVleWyZOrkwaO4i0k=; b=RwLwo4xbJzw/5bIjddpiirbA60bVO3IYnAxPMIjCVXNAENy1PVG8FQALVfpRdFgTRy aBVnZTdvsovWQ6laytKDk4I7VOfCVlT0cjBPEfppAcjkT2StFppX8p9To8ceS33s51o8 jKQCbVcCIyuVHlNdfO0Wt3GR+wZDa6R3vuG8QmdjHLsXM0bzCGzgeHAiXjyA+3A3eE8i Hev1btDMt68kQIGnvCp1yCRZEG98HEalGU0DLrrOz6BSrsC2yZ4dfi2LxG6jVFUTI5Md vQ+2pbQAm7ATmH/b09TvcxbJy/9iOz2QV2NEtSxx0CK/USqJrgBAyS41yANIuvhq+/14 Zh5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751055588; x=1751660388; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pXVRSgb2FwoGmCqMjR70aPhAiVZVleWyZOrkwaO4i0k=; b=NWml3JTt7t7RiJqKUfWSWCpxJOIY59ch7nEbObRAnLleN6mc0s9V6QsFuK2hVaq87G MrKsSZ89AP7zwEezobFbHokqROy2QDu9NaPNL0otJMuae26XhVo/DyswEyLgo0DEZj10 iMCmqK5KEKH0q+vEY8qqzEG9HbTf7YeU217w8v25TMk5S+cslG1bmN0RY3MSw4Zi9IX7 rz4WoOJ4Ikj6s+lM6+E+MQztV5QCLqqiwqkQVxlnDNnjgiFJ47vcKVwV2p9byLtxZOsq VbFRFZbrDqSUbRcQHvVKXElH5kGdTP9F2vynHlfZt81lmcYbHnGHGuC2Kds97hWamAHV hMHg== X-Forwarded-Encrypted: i=1; AJvYcCU5rBkAWB/w1BS1D1u6FKp09VktPC4JdnH2CX2gbTCs+0drVHvu64pNU4CsGHHxrgb2iZ52TdjEi4VcJCQ3AZGTznNr@freebsd.org, AJvYcCUKkK7DZxbj2ah6o11N6Gv+QyVdpzSm6niMXv25jyjZ3zmRLaF4miAS7YwhLIQ+FK+14WN/POe5FZD6/gnZ6xs=@freebsd.org, AJvYcCUtY/0D261e8DhouIr4fO8mzZhVjsNppOET2JBhKRk0QUnjZJ9k9Pv60BxhOHr8nzx2N23m@freebsd.org, AJvYcCXnqQeAH8yGENoE/x/Go5OLz6+/0qsvFCmjnbchYbAjEtoM65esGOFISnKNxiYkq+p9+a74daJb@freebsd.org, AJvYcCXu/Z7vhalhvmOIur6m/UtuAJvtgdY11xVBupdoQLmX2fBv7k7ut2js8S7MTCEBCzD2vyiwcjXM9O6tMaWFW6mrIaBCfJk=@freebsd.org X-Gm-Message-State: AOJu0YwPa1FSKrXRURIeO4QQOPR2Ju0/Q7jKldzKJm8m0ijcQvQNerf/ c/yr0Rrgw6se13IhyRNckae6wGuMthivHlgk3A4gvhCPotMQszNAQwk34+b79rkO X-Gm-Gg: ASbGncvTYua0lJrZLem3XnDRHxb96QEOAcbCx9Y0wDeDxdKq4p42tgGRHXeeb9w500N 2aHObN2lAHS1IY/3Eq6gFWdljJaMSBsb4zTb/UgGAoNKWY0/iWo35NijSf80P+HZ2V1WjM/FXvv 3rIOjWV6h+SmLZz3wpIxt3QkTFihVRIzz1dePEba93VvZ1lOU4tTkjwyBY3PKdLf9ybX/SoAkml Bu7G4B5zOQ6yea8hyERnrpcS/RG28bhkTMd+Q6pFfLQN4ljjCPwEooepzPzXpTeOUcpPBHiGC1D hzE7TbXBYCKr1oG9MnVW6JJdsz1BW7B364cJb98MI+rJf1EJCwFIbgBXs8YsXrjVIBI/GlypRFq g X-Google-Smtp-Source: AGHT+IEC8Ho87w74aqZDIiA+poqz4qyfqnD1eYKXZO/FTuzXcOQfImPeHX487dJ8NzC9FoxUxRttIQ== X-Received: by 2002:a05:620a:4623:b0:7d4:434e:2c17 with SMTP id af79cd13be357-7d44398e560mr668740685a.17.1751055587620; Fri, 27 Jun 2025 13:19:47 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d443204beasm188868585a.65.2025.06.27.13.19.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jun 2025 13:19:47 -0700 (PDT) Date: Fri, 27 Jun 2025 16:19:44 -0400 From: Mark Johnston To: Gleb Smirnoff Cc: Baptiste Daroussin , Hiroki Sato , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, srcmgr@freebsd.org Subject: Re: git: 4deb9760a9d8 - main - rc: Disable pathname expansion when calling run_rc_command() Message-ID: References: <202506121820.55CIKQTQ097365@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4bTRjy3ySbz3Kql X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] On Fri, Jun 27, 2025 at 12:37:52PM -0700, Gleb Smirnoff wrote: > On Fri, Jun 27, 2025 at 08:56:23PM +0200, Baptiste Daroussin wrote: > B> On Wed 18 Jun 10:13, Mark Johnston wrote: > B> > On Thu, Jun 12, 2025 at 06:20:26PM +0000, Hiroki Sato wrote: > B> > > The branch main has been updated by hrs: > B> > > > B> > > URL: https://cgit.FreeBSD.org/src/commit/?id=4deb9760a9d84d5861ee45162ffebe83f13503b8 > B> > > > B> > > commit 4deb9760a9d84d5861ee45162ffebe83f13503b8 > B> > > Author: Hiroki Sato > B> > > AuthorDate: 2025-06-12 18:19:32 +0000 > B> > > Commit: Hiroki Sato > B> > > CommitDate: 2025-06-12 18:19:32 +0000 > B> > > > B> > > rc: Disable pathname expansion when calling run_rc_command() > B> > > > B> > > Variables for command-line options like $foo_flags can contain characters > B> > > that perform pathname expansions, such as '[', ']', and '*'. They were > B> > > passed without escaping, and the matched entries in the working directory > B> > > affected the command-line options. This change turns off the expansion > B> > > when run_rc_command() is called. > B> > > > B> > > While this changes the current behavior, an invocation of a service > B> > > program should not depend on entries in the working directory. > B> > > B> > This also turns off globbing for /etc/rc.local, which broke one of my > B> > scripts. Was that intentional? If so, we should really document it in > B> > RELNOTES at the very least. > B> > B> This broke nuageinit which rely on globbing to in nuageinit_start, that this > B> change also broke. > B> > B> So many downstream CI are now broken, due to this change. > > Given that Hiroki is not reacting on this email thread neither in > https://reviews.freebsd.org/D51043, I would like to revert this change. I'd > like also remind that the problem was discovered during the stabweek testing. > Although we thawed the freeze, but we are still working on a good known stable > revision for June. > > Any objections? > > Adding srcmgr@ I've reverted the change (and a follow-up fix) for now.