From owner-cvs-all@FreeBSD.ORG Sat Dec 27 18:21:12 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3893B16A4CE; Sat, 27 Dec 2003 18:21:12 -0800 (PST) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0876D43D3F; Sat, 27 Dec 2003 18:21:11 -0800 (PST) (envelope-from sam@errno.com) Received: from 66.127.85.93 ([66.127.85.93]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.9) with ESMTP id hBS2LAHQ042785 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Sat, 27 Dec 2003 18:21:10 -0800 (PST) (envelope-from sam@errno.com) From: Sam Leffler Organization: Errno Consulting To: Mike Silbersack Date: Sat, 27 Dec 2003 18:20:55 -0800 User-Agent: KMail/1.5.4 References: <200312280143.hBS1hMwD065855@repoman.freebsd.org> <20031227195427.Y46996@odysseus.silby.com> <200312271803.21069.sam@errno.com> In-Reply-To: <200312271803.21069.sam@errno.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200312271820.55326.sam@errno.com> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha vm_machdep.c src/sys/amd64/amd64 vm_machdep.c src/sys/i386/i386 vm_machdep.c src/sys/ia64/ia64 vm_machdep.c src/sys/powerpc/powerpc vm_machdep.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Dec 2003 02:21:12 -0000 On Saturday 27 December 2003 06:03 pm, Sam Leffler wrote: > On Saturday 27 December 2003 05:56 pm, Mike Silbersack wrote: > > On Sat, 27 Dec 2003, Sam Leffler wrote: > > > > Move the declaration of sfbufspeak and sfbufsused to mbuf.h, > > > > and use imax instead of max, as sfbufspeak and sfbufsused > > > > are signed. > > > > > > These have nothing to do with mbufs; why move the decls to mbuf.h? > > > > > > Sam > > > > Because I can't think of anywhere else sendfile related values would fit. > > So far our only use of sfbufs in the system is to attach them to mbufs > > and send them out via sockets. FWIW, I'm about to overload mbstat with > > some sendfile statistics as well, because I can't think of another place > > that they would fit well. I'm open to ideas, as long as they don't > > involve creating yet another header file. > > Looks like there's an sf_buf.h. If that's not to your liking perhaps > systm.h or kernel.h. Please don't pollute mbuf.h. Looks like this stuff had already landed in subr_mbuf.c so I guess mbuf.h makes sense. Sure wish this stuff had been kept separate; it doesn't make sense to me that it's being tossed in to the mbuf code. Sam