From owner-svn-src-head@freebsd.org Sat Jan 13 18:04:37 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EAD85E76B6F; Sat, 13 Jan 2018 18:04:37 +0000 (UTC) (envelope-from kevlo@ns.kevlo.org) Received: from ns.kevlo.org (220-135-115-6.HINET-IP.hinet.net [220.135.115.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "ns.kevlo.org", Issuer "ns.kevlo.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9AEE46FF88; Sat, 13 Jan 2018 18:04:37 +0000 (UTC) (envelope-from kevlo@ns.kevlo.org) Received: from ns.kevlo.org (localhost [127.0.0.1]) by ns.kevlo.org (8.15.2/8.15.2) with ESMTPS id w0DI2UFw096871 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 14 Jan 2018 02:02:31 +0800 (CST) (envelope-from kevlo@ns.kevlo.org) Received: (from kevlo@localhost) by ns.kevlo.org (8.15.2/8.15.2/Submit) id w0DI2TMF096869; Sun, 14 Jan 2018 02:02:29 +0800 (CST) (envelope-from kevlo) Date: Sun, 14 Jan 2018 02:02:29 +0800 From: Kevin Lo To: Pedro Giffuni Cc: Justin Hibbits , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Subject: Re: svn commit: r327906 - in head/sys: conf powerpc/mpc85xx Message-ID: <20180113180229.GA96844@ns.kevlo.org> References: <201801130136.w0D1abhS054355@repo.freebsd.org> <40f39e41-f051-0758-fe15-55c1dab64c9c@FreeBSD.org> <3bd7260a-4bac-2718-9836-15bb25cbc793@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3bd7260a-4bac-2718-9836-15bb25cbc793@FreeBSD.org> User-Agent: Mutt/1.8.0 (2017-02-23) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jan 2018 18:04:38 -0000 On Sat, Jan 13, 2018 at 10:38:43AM -0500, Pedro Giffuni wrote: > > ... > > > On 13/01/2018 10:33, Justin Hibbits wrote: > > > > > > On Jan 13, 2018 09:04, "Pedro Giffuni" > > wrote: > > > > > > > > On 12/01/2018 20:36, Justin Hibbits wrote: > > > > Author: jhibbits > > Date: Sat Jan 13 01:36:37 2018 > > New Revision: 327906 > > URL: https://svnweb.freebsd.org/changeset/base/327906 > > > > ... > > > > > > Added: head/sys/powerpc/mpc85xx/mpc85xx_cache.c > > ============================================================================== > > --- /dev/null   00:00:00 1970   (empty, because file is newly > > added) > > +++ head/sys/powerpc/mpc85xx/mpc85xx_cache.c Sat Jan 13 > > 01:36:37 2018        (r327906) > > @@ -0,0 +1,129 @@ > > +/*- > > + * Copyright (c) 2018 Justin Hibbits > > + * All rights reserved. > > + * > > + * Redistribution and use in source and binary forms, with or > > without > > + * modification, are permitted provided that the following > > conditions > > + * are met: > > + * 1. Redistributions of source code must retain the above > > copyright > > + *    notice, this list of conditions and the following > > disclaimer. > > + * 2. Redistributions in binary form must reproduce the above > > copyright > > + *    notice, this list of conditions and the following > > disclaimer in the > > + *    documentation and/or other materials provided with the > > distribution. > > + * > > + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS > > ``AS IS'' AND > > + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > > LIMITED TO, THE > > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A > > PARTICULAR PURPOSE > > + * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR > > CONTRIBUTORS BE LIABLE > > + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, > > OR CONSEQUENTIAL > > + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF > > SUBSTITUTE GOODS > > + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > > INTERRUPTION) > > + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > > CONTRACT, STRICT > > + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > > ARISING IN ANY WAY > > + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE > > POSSIBILITY OF > > + * SUCH DAMAGE. > > + * > > + * $FreeBSD$ > > + */ > > + > > > > > > Can we please add SPDX ID tags, specially on new code? > > I had them added to the guidelines: > > > > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/pref-license.html > > > > > > It is just not fun for me anymore to go hunting for untagged files > > and they keep appearing ;). > > > > Pedro. > > > > > > D'oh, sorry. I had used an existing boilerplate template I have lying > > around that didn't have the SPDX tags. I'll update and fix this. > > > It's OK, no hurry. The diff below adds SPDX tag to the example copyright. Index: share/examples/etc/bsd-style-copyright =================================================================== --- share/examples/etc/bsd-style-copyright (revision 327932) +++ share/examples/etc/bsd-style-copyright (working copy) @@ -1,4 +1,6 @@ /*- + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD + * * Copyright (c) [year] [your name] * All rights reserved. *