From owner-svn-src-head@FreeBSD.ORG  Sun Nov 20 19:05:49 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6DB061065676;
	Sun, 20 Nov 2011 19:05:49 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 29FBD8FC15;
	Sun, 20 Nov 2011 19:05:49 +0000 (UTC)
Received: from 63.imp.bsdimp.com (63.imp.bsdimp.com [10.0.0.63])
	(authenticated bits=0)
	by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id pAKJ0EcZ049452
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO);
	Sun, 20 Nov 2011 12:00:14 -0700 (MST) (envelope-from imp@bsdimp.com)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <201111200836.pAK8aIEq082864@svn.freebsd.org>
Date: Sun, 20 Nov 2011 12:00:13 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <229B993A-8F52-42B3-AE87-7DB4451AA9D0@bsdimp.com>
References: <201111200836.pAK8aIEq082864@svn.freebsd.org>
To: Hans Petter Selasky <hselasky@freebsd.org>
X-Mailer: Apple Mail (2.1084)
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(harmony.bsdimp.com [10.0.0.6]);
	Sun, 20 Nov 2011 12:00:14 -0700 (MST)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r227749 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Nov 2011 19:05:49 -0000

Is this right?  Passing 0 to timo causes a panic?  That can't be good.

Wanrer


On Nov 20, 2011, at 1:36 AM, Hans Petter Selasky wrote:

> Author: hselasky
> Date: Sun Nov 20 08:36:18 2011
> New Revision: 227749
> URL: http://svn.freebsd.org/changeset/base/227749
>=20
> Log:
>  Given that the typical usage of pause() is pause("zzz", hz / N), =
where N can
>  be greater than hz in some cases, simply ignore a timeout value of =
zero.
>=20
>  Suggested by:	Bruce Evans
>  MFC after:	1 week
>=20
> Modified:
>  head/sys/kern/kern_synch.c
>=20
> Modified: head/sys/kern/kern_synch.c
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/sys/kern/kern_synch.c	Sun Nov 20 08:29:23 2011	=
(r227748)
> +++ head/sys/kern/kern_synch.c	Sun Nov 20 08:36:18 2011	=
(r227749)
> @@ -333,7 +333,7 @@ msleep_spin(void *ident, struct mtx *mtx
> int
> pause(const char *wmesg, int timo)
> {
> -	KASSERT(timo > 0, ("pause: timo must be > 0"));
> +	KASSERT(timo >=3D 0, ("pause: timo must be >=3D 0"));
>=20
> 	/* silently convert invalid timeouts */
> 	if (timo < 1)
>=20
>=20