From owner-freebsd-current@FreeBSD.ORG  Sun Nov  9 21:10:12 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id BE1DB16A4CE; Sun,  9 Nov 2003 21:10:12 -0800 (PST)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4657543FDD; Sun,  9 Nov 2003 21:10:10 -0800 (PST)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 2CCE62ED479; Sun,  9 Nov 2003 21:10:10 -0800 (PST)
Date: Sun, 9 Nov 2003 21:10:10 -0800
From: Alfred Perlstein <bright@mu.org>
To: current@freebsd.org
Message-ID: <20031110051010.GC33733@elvis.mu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.1i
cc: dfr@freebsd.org
Subject: taskqueue patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Nov 2003 05:10:12 -0000

I noticed that init was complaining about processes not exiting
when doing a transition to single user mode.  It appears
that the problem is that the taskqueue kernel process is 
started with RFNOWAIT but doesn't respect orderly shutdown
signs.

Diff follows:

Index: subr_taskqueue.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/subr_taskqueue.c,v
retrieving revision 1.19
diff -u -r1.19 subr_taskqueue.c
--- subr_taskqueue.c	6 Sep 2003 21:05:18 -0000	1.19
+++ subr_taskqueue.c	10 Nov 2003 05:00:00 -0000
@@ -271,7 +271,7 @@
 
 TASKQUEUE_DEFINE(thread, taskqueue_thread_enqueue, 0,
 		 kthread_create(taskqueue_kthread, NULL,
-		 &taskqueue_thread_proc, RFNOWAIT, 0, "taskqueue"));
+		 &taskqueue_thread_proc, 0, 0, "taskqueue"));
 
 int
 taskqueue_enqueue_fast(struct taskqueue *queue, struct task *task)


-- 
- Alfred Perlstein
- Research Engineering Development Inc.
- email: bright@mu.org cell: 408-480-4684