From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 00:53:56 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ACC9F106566C for ; Wed, 20 Apr 2011 00:53:56 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 5DF6A8FC08 for ; Wed, 20 Apr 2011 00:53:56 +0000 (UTC) Received: by iyj12 with SMTP id 12so276240iyj.13 for ; Tue, 19 Apr 2011 17:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:date:from:to:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:x-openpgp-key-id:x-openpgp-key-fingerprint :x-openpgp-key-url; bh=nvBb7fPqoaxLevpkzGimHCCuBYercccOdVhgQFoNYSY=; b=c9j6EafBQtAeD4Gie9PZuo6L8bz+SsT6wFY/3v6hYBXNfBa3OaXm5+uO+R8HWsjH2p n3GSOoQ85DaZRAZGcefUgVuQYmwHBH8CVdZcPR/vxzpqIlPp+NrRhe67KQVc+Pol2VLM 6s73Oc15hEk+OtfbwuZSBfzg+zMe/kzGv2Uik= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-openpgp-key-id :x-openpgp-key-fingerprint:x-openpgp-key-url; b=m1vfwwn1IvKjY0n0F2rsxOifISMlvMq0vYRhDSwrSzD/7TSQQferWTjSu3eGplidaI +dNoz3GKu2Hz2ZEcy2jQAYgYD8CsF9ZQ1bvc/r+8IN4r4qYPlDrfPCUfSvmPCOfvZKue d83w3HFZAKmlS1U2hwjgxkCwd4cJyfBj6soSY= Received: by 10.231.25.94 with SMTP id y30mr5408849ibb.61.1303260835547; Tue, 19 Apr 2011 17:53:55 -0700 (PDT) Received: from DataIX.net ([99.190.84.116]) by mx.google.com with ESMTPS id o3sm151123ibd.27.2011.04.19.17.53.53 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 19 Apr 2011 17:53:54 -0700 (PDT) Sender: "J. Hellenthal" Received: from DataIX.net (localhost [127.0.0.1]) by DataIX.net (8.14.4/8.14.4) with ESMTP id p3K0roD9090404 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 19 Apr 2011 20:53:51 -0400 (EDT) (envelope-from jhell@DataIX.net) Received: (from jhell@localhost) by DataIX.net (8.14.4/8.14.4/Submit) id p3K0rnNA090403; Tue, 19 Apr 2011 20:53:49 -0400 (EDT) (envelope-from jhell@DataIX.net) Date: Tue, 19 Apr 2011 20:53:49 -0400 From: "J. Hellenthal" To: Bruce Cran , freebsd-current@freebsd.org Message-ID: <20110420005349.GF2483@DataIX.net> References: <20110419111500.GA16509@muon.cran.org.uk> <20110419122210.GL85668@acme.spoerlein.net> <20110420001737.GE2483@DataIX.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZYOWEO2dMm2Af3e3" Content-Disposition: inline In-Reply-To: <20110420001737.GE2483@DataIX.net> X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E X-OpenPGP-Key-URL: http://bit.ly/0x89D8547E Cc: Subject: Re: Finding typos using codespell X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 00:53:56 -0000 --ZYOWEO2dMm2Af3e3 Content-Type: multipart/mixed; boundary="3607uds81ZQvwCD0" Content-Disposition: inline --3607uds81ZQvwCD0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 19, 2011 at 08:17:37PM -0400, J. Hellenthal wrote: >On Tue, Apr 19, 2011 at 02:22:10PM +0200, Ulrich Sp=F6rlein wrote: >>On Tue, 19.04.2011 at 12:15:00 +0100, Bruce Cran wrote: >>> There's a new tool that can be used to find spelling mistakes in code: = codespell=20 >>> from http://www.politreco.com has already been used to find mistakes in= both=20 >>> Linux and LLVM. I ran it on sys/ and it found lots of potential typos -= the=20 >>> full diff (which I know does contain some incorrect changes) can be fou= nd at=20 >>> http://www.cran.org.uk/~brucec/freebsd/codespell_sys.diff . >> >>Needs manual review, but I think this is very useful for the spelling >>nazi challenged among us :-) >> >>False positive, e.g.: >> { >>- struct ccb_immed_notify *inot; >>+ struct ccb_immed_notify *into; >> mpt_tgt_state_t *tgt; >> >>Cheers, >>Uli > >As mentioned here already changes that I have noticed are: > >(Upper || lower case): >inot -> into >lsat -> last >inbetween -> between >ALOT -> A LOT >boundry -> boundary "This one seems to have corrected itself." >virtualY -> virtually >ID -> DID >lastr -> last >*Any uuencoded file* > >This was just a review of the functional changes. The no-op changes I >just filtered out of the patch to quickly catch the "Bad Thing" changes >above. > >It might just be better to build a list of files with spelling errors >and anyone with the next commit to any of those files just runs it >through aspell/ispell or whatever they like rather than causing this >much of a slush. > >All in all good find Bruce!. > Meant to attach the final list I came up with for further use if needed but forgot on send... Here it is. --=20 Regards, J. Hellenthal WWJD --3607uds81ZQvwCD0 Content-Type: application/octet-stream Content-Disposition: attachment; filename="codespell_sys.txt.gz" Content-Transfer-Encoding: base64 H4sICOMtrk0CA2NvZGVzcGVsbF9zeXMudHh0AO1aWW/bSBJ+1vyKhgEbpClmnexgHzaJAcaS HSGypJHorL2ZoEGRLYswRXLIlo/Z/PitPngfomxjAywmQBKp+6uT1VXVJeo9+IOQcrAgPkWG OZr+bTSZmkg5DNXf/YM+2sYkwra9VNX3v2h1YHNaD9Z7vZhGW5siWMDuZkMc7AfUXT2hYxc+ cHYtCBpwHgyKPiKlAXmsbizPC2wldv8kwUrhrNU+usSLs8Xo0+c+k8KY7ceDBgUeTI8VUoQu H9HkajxW0X84a77M2GfLgH4MKY4J3YbMG8oRI9RPmdx1H4UkcsO1fhpaFL6dGZd4Nh9N5yPz Bk+m80tjrKaGS5o3q61vYztwCFhxPTPx6PJyOAC0OTq/qYDt5cr2Q0BSK7pdrp3AJ+8TnSyb uoGvKFsf/mOOQMcq95h8XhbdxkCZZycW+dOqWEWDvaySj6KbVSVwrVVam1XwDGWMpVZl7BKr wOreKiKEP9vskctglzs0KOwAzWI8WoDCk8VwbuLPQ2OgHMXBitr6aT6wcOy5MXAtPH/GeG/y zNEgXYZxHNh3luNE2KLIiy0AHsO/TPE6gBWnANB/+SeJAkWx+TZVjwS9jP8quTzPDPUG/mKP +ODPZngRzVbfxGAUf9KGaQwGc2xMbibTwbAeSWgRODSLuJW1cb0nhjnHxmw2HprG+IsIYYuR cnv4I6wYyv3QaihQMVRHQ/PodkPrkHWG5nENhmqZoYBkhkOIQHyvPPd2zdZP+igiMfEd8dn1 l4Q+EG4MfLXsOyJ3rGVwz5Q9YUzbmXRgwU5TKkvTxCHKfdV5vlRSGafoREU/frAUmnBnSyK3 NkDLQJ2VJJTqnTM2UV+qKJUWz6xIsotA7y0t33lwWWpziGc9Ack2iimPDMZPbDsN+8wtJIqC CLzk3+IlZSFEKI5WdrDZ4BAONhOrwIc+MsZTU6af7jRIEIGgPfjvw3Yfvvsw3tki7OwQXs5h V48B1QSW1u87tBIpVJwElvU3JI6tW4KhbMXfTr4DMbmH9kk/5f9h+hSSRvjbChyWhY9FTejE vAHewDztJlzfpa5Fgwi7TobMr+bA8GxjItPlSdpusCpd22ykxb2LkBRcEqI1C+G1/6/Y+Cs2 mmODVQDl4Fu4sfuHznf04JLIQWezKwTCDh24zGA8Hk2GGPeRHW5FY1CmIe4umpKcZ4jpJmWL 7bUVIbQMtr4TPTEuhSWLrbHGT+yzpga6TZ88UhyyKkeRjt6+Ty46CeoDR0XEBhCEBjTNEVV5 QBb55BBBKDhpEmM1C9NywqxGaVqvwqlGHOjEDppr42BLl0ps9xHcJWYn+NNkftNP3CKiayfQ 4kidPYYIrjuRrxxs/bvgwT9gDErLvlwXPdi9G9Gt5V33k083SWNV2fH4E1GO710nfvimWE6o 6qf3FnZ9hzx+h4i27gmY6RFKiarw/T5SYAFWiKq20nqB5bTRas+RyxfaaRvlSlq9J1qvg9mW ovP5cIj4tMHb+hDZfIQAH2UXUcaZ0yruNVL87gyPFqYxGv+Gz0fzhakc0YiGLA8FNFaTnrY6 GthdDVrZag2jBe6VC5L33mGYd4y4yOZv8OzGDJ1Y4tkyB/BrmQO78OZvywUOem9DNjGhyVhD ZF7HolafXQfEZUl4JL+pqomzayqC5FgtczUs89siX2b6ZJWgRp/ipiBtKB6pPuXKWMOyrI/e XN0vFxfY+DSFS79pXOSK107kDp5n46ExB+TiC17IK2Qb4zJ8B3fTmF8MTTwfduFdBHfS2zgz OqrMkT/Bv5PpdLaTnQDpPXorTh47/PnOA4mMpPeq0zWAsonZ5XCxMC6G4Lyzrz/YwmD4Ff92 Pv/3hAlv4csSmdarzrc68NV3NWPtbZQbh3gNl18PSoZn0VUQbdLplR27CuzzyRamkHDjkKUV DG1c9MQXmIxftBfyAEVYLbwPXAd8AbwkLXQaioRLU1oxsi2s1AvoNUmhqCCRjmvn1yUwrwAC nHTxdSWhQAVlgU8Hk6oQ0ihfFZqvGd25cF1kPpVz7LTayJFKrzdazPDMMD/j2dwUPmIr4+mF ORh+uro4KdYYMfY9OIz/iUzrjuSqkw0dFUXQJSXlBWM++IXuNdMKc1TyE0MX0VmoN4iGsraf 6I5WC0po+kgEUqGJRFAKuKXigWwjEv8uOsUXMQT9ywz1ymMrPDVW2Nn0BR4KXNg8NsuK7vmU TvZCbQDeC7WcxHe/Pj7WnsSVLc4iA3Q71HuwEmfbD9eOl/4sAUC+wByc7YgLY7IDngqDiLpO nkqs4LWLPnxAb/+BflS2PJ5H86SSbR1pccsTw6gHl9rrpFOBXZGHxdPKNiVptsnrD5xl8BiI ZRHCiujX2WhwneUwTnMfus5jektupZBSEgqW2+rVw/F2yX6HkUHVoGcelc8gNRDWss4gxkdq Ibe0I3V5WhaT2RzC/1xZbldZrwVf4CpxMBwv0Mnj4eNBziUl9cTB249TvaGFE8cBK8+6jdER HM93v15f4/OxcYFnV/PhNR5Nzz6VDmVHinSALWVEj66Tsy6Ar0KTLiVOspLCE1byq2Sl9bpV Qm4HIFZwu8Ohs8TLJwjzAMIpS2TtYdpH/Dz20ZEXqmncAEuHePjhQZbx7tw8uCCx88ZoU97J YmLbs9QunJWK2tqeape47VZbF/zDiBZqxGhyPoVQPWOH/NBBhzFU/e1Sl80di14VQWZFE51x QiLfJlHdxaFQehoPktRUOvV/ol3Jb1K72sOZadf1ZHSK+VfjtLONrJtNVNrHtvnEPv3efiOK ffrRhhcgasfE7Ooh74f/Go0HZ8Z80DzurQU3cWaHScRXM8M8JhtE/CE2hbW8L6LW7b3lZRj4 3oBBp6fo7+/yY4RmbglmNzeZC+TMZWNFd9hawgEiDiZW5Mm8Q3NHV/DMjx6AtnTJXXxJz3FH zpm2+aF8PedWwaWZRDOkhkvdhKB2t5G2VYPGSUgGYYnuzBjjq8moOgNph9Vwa5ilNAH0n3QN 6zik6DA++Dl3uY7DkE7zDXZcxGGtXlpyJK7NftnemfbF1eg1eYo70rPj5BsryN9RylkmJl65 2RZaRcFGfMpVdsQiln0oPgs5oM6npay/yLJxsiYSZr/mfbNkDcS8LIxe1zwt119n5pWLTbKW mVeOxWRNmKf3oH9IX3Rjj1mU/GRgyHfTwpF3brqblp68Y9PdUiWsPhDm4ooOvDlIWpWyDpkH 0t2cDpn16W5Fh7LXXrdr6to2wTqH7w4wQJbiS8YWz69pPMXs5SQXOuI4/TmmfBSSuEjiSm19 faBOYe2FCkNCbVa4Gtw1CmcezolJYrejR2syktQwIvaT7RUOK2iUnchmrxZ8Waua9swBY2fV mvyndnkNd/crrXrveQ+/8JNrH+KM/MHeKBD3tHJ5TWcoL5BiTndK+X+zBfE/q/hNyH8RR6cf 2Rc+LtBP2buaETo6qkV+qAA19PUSnxtXY9YNGgNVZaRaFyFNwLKMehGgXVmVjzkmGlpZW48K 83W0JGtY53FbYt6B6L9X4GLvfjAAAA== --3607uds81ZQvwCD0-- --ZYOWEO2dMm2Af3e3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) Comment: http://bit.ly/0x89D8547E iQEcBAEBAgAGBQJNri6cAAoJEJBXh4mJ2FR+YAsIAJOECKsj68YAbj+/jLWOtzOx nN9fj1YyaCjlflw3m7vNrTyoqtpm5LCVCPzGZ5x1/4+dTZT0DL75i9Nd5+emKYCw x5eW+cD8BzyakA5luoc2IQndef6zzufRPSKdou3ls++BKQCzeEqbbEBnVMnQNJZa JEI5ydTqkqVqyGms9xoC4fpNVtJdr4IkrzspartvIJ2r6Xmnx/1K9tjXcvP0ZAiK ndmyAKrYRBSbyMg3Jk7xyQxewB2cAkaUCM5YuBplfumolZjmRhYgIleN5DdPr4Nf MuMMTN72mZToF6YrzdFsM7nWGDencbOQnu6t/TgHlUFvHins486vXXbXjt0A8rY= =oI/X -----END PGP SIGNATURE----- --ZYOWEO2dMm2Af3e3--