From owner-cvs-all@FreeBSD.ORG Thu Jul 29 09:21:19 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C57C16A4CF for ; Thu, 29 Jul 2004 09:21:19 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 55B9343D3F for ; Thu, 29 Jul 2004 09:21:18 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 83865 invoked from network); 29 Jul 2004 09:17:16 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 29 Jul 2004 09:17:16 -0000 Message-ID: <4108C179.D4FF44B1@freebsd.org> Date: Thu, 29 Jul 2004 11:20:57 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Nate Lawson References: <200407282235.i6SMZfdU014440@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fdc fdc_acpi.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2004 09:21:19 -0000 Nate Lawson wrote: > > njl 2004-07-28 22:35:41 UTC > > FreeBSD src repository > > Modified files: > sys/dev/fdc fdc_acpi.c > Log: > Fix ACPI floppy enumeration for three types of divergent behavior. > * Some systems have _FDE and child floppy devices, but no _FDI. This seems > to be compatible with the standard. Don't error out if there is no _FDI. > Instead, continue on to the next device. The normal fd probe will take > care of this device. > * Some systems have _FDE but no child devices in AML. For these, add a > second pass that compares the results of _FDE to the presence of devices. > If not present, add the missing device. > * Some BIOS authors didn't read the spec. They use tape drive values for > all fdc(4) devices. Since this isn't grossly incompatible with the > required boolean value, use them. They also define the _FDE items as a > package instead of buffer. Regenerate the buffer from the package if it > is present. > > Tested by: tjr, marcel Is there any kind of feedback chain towards the BIOS authors so they might fix it in the next release? -- Andre