From owner-freebsd-ports Mon Sep 25 5:25: 8 2000 Delivered-To: freebsd-ports@freebsd.org Received: from smtp10.atl.mindspring.net (smtp10.atl.mindspring.net [207.69.200.246]) by hub.freebsd.org (Postfix) with ESMTP id 5077837B42C; Mon, 25 Sep 2000 05:24:58 -0700 (PDT) Received: from silvia.hip.berkeley.edu (sji-ca1-01.ix.netcom.com [209.109.232.1]) by smtp10.atl.mindspring.net (8.9.3/8.8.5) with ESMTP id IAA30773; Mon, 25 Sep 2000 08:24:49 -0400 (EDT) Received: (from asami@localhost) by silvia.hip.berkeley.edu (8.11.0/8.11.0) id e8PCOjs25220; Mon, 25 Sep 2000 05:24:45 -0700 (PDT) (envelope-from asami) To: Kris Kennaway Cc: Peter Pentchev , ports@FreeBSD.org Subject: Re: unbreak devel/cdk port, raise minor PORTREVISION issue References: From: asami@FreeBSD.org (Satoshi - Ports Wraith - Asami) Date: 25 Sep 2000 05:24:39 -0700 In-Reply-To: Kris Kennaway's message of "Mon, 25 Sep 2000 03:06:21 -0700 (PDT)" Message-ID: Lines: 32 X-Mailer: Gnus v5.7/Emacs 20.7 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org * From: Kris Kennaway * On Mon, 25 Sep 2000, Peter Pentchev wrote: * * > Your recent commit to ports/devel/cdk/Makefile breaks builds of the port. * > Actually, this seems to be a common problem with most ports now that * > the PORTREVISION/PORTEPOCH system is in place - most ports with bumped * > PORTREVISION would need an additional (constant) line: * > * > WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} * * The solution would actually be to do this in bsd.port.mk. No, that is not necessary. I made sure PORTREVISION or PORTEPOCH will only affect PKGNAME, not DISTNAME (and thus the default WRKSRC). DISTNAME is supposed to go into ${WRKSRC} by default (and always has, as long as it existed) and I don't see why we need to change that now. The real reason of the devel/cdk breakage is the WRKSRC=${WRKDIR}/${PKGNAME} line in its Makefile. Instead of defining DISTNAME and WRKSRC, it should have just used DISTFILES. It will reduce the line count too. I did a search and this was not the only port that defined WRKSRC as ${WRKDIR}/${PKGNAME}. I committed fixes to all 52 of them just now. Most of them were the same DISTNAME/WRKSRC[/EXTRACT_SUFX] instead of DISTFILES mistakes. Some of the WRKSRC definitions weren't even necessary (as nobody was changing DISTNAME). Satoshi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message