From owner-svn-src-all@FreeBSD.ORG  Sat Dec  8 00:00:46 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 0FD67CFF;
 Sat,  8 Dec 2012 00:00:46 +0000 (UTC)
 (envelope-from carl.r.delsey@intel.com)
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
 by mx1.freebsd.org (Postfix) with ESMTP id AB8DD8FC14;
 Sat,  8 Dec 2012 00:00:45 +0000 (UTC)
Received: from azsmga002.ch.intel.com ([10.2.17.35])
 by azsmga102.ch.intel.com with ESMTP; 07 Dec 2012 16:00:44 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.84,241,1355126400"; d="scan'208";a="177722130"
Received: from crdelsey-fbsd.ch.intel.com (HELO [10.2.105.127])
 ([10.2.105.127])
 by AZSMGA002.ch.intel.com with ESMTP; 07 Dec 2012 16:00:44 -0800
Message-ID: <50C2832C.9080501@intel.com>
Date: Fri, 07 Dec 2012 17:00:44 -0700
From: Carl Delsey <carl.r.delsey@intel.com>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:13.0) Gecko/20120724 Thunderbird/13.0.1
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>
Subject: Re: svn commit: r243960 - in head/sys: amd64/include i386/include
 x86/include
References: <201212062233.qB6MXWpP046167@svn.freebsd.org>
 <201212071208.28158.jhb@freebsd.org>
In-Reply-To: <201212071208.28158.jhb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, Jim Harris <jimharris@freebsd.org>,
 svn-src-all@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Dec 2012 00:00:46 -0000

On 12/07/12 10:08, John Baldwin wrote:
> On Thursday, December 06, 2012 5:33:32 pm Jim Harris wrote:
>> Author: jimharris
>> Date: Thu Dec  6 22:33:31 2012
>> New Revision: 243960
>> URL: http://svnweb.freebsd.org/changeset/base/243960
>>
>> Log:
>>    Add amd64 implementations for 8-byte bus_space routines.
>>    
>>    Submitted by:	Carl Delsey <carl.r.delsey@intel.com>
>>    Discussed with:	jhb, rwatson
>>    Reviewed by:	jimharris
>>    MFC after:	1 week
>>
>> Modified:
>>    head/sys/amd64/include/bus.h
>>    head/sys/i386/include/bus.h
>>    head/sys/x86/include/bus.h
> Do we still want the link errors on i386?  Do you get a compile error now?
>
You get a compile error now, since the function prototypes don't exist 
for i386. That was the case in the old code too. The comments about 
forcing a link error were incorrect or obsolete.