From owner-freebsd-doc Mon Mar 10 17:36:14 2003 Delivered-To: freebsd-doc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3B33137B401; Mon, 10 Mar 2003 17:36:13 -0800 (PST) Received: from perrin.int.nxad.com (internal.ext.nxad.com [69.1.70.251]) by mx1.FreeBSD.org (Postfix) with ESMTP id B22C243F75; Mon, 10 Mar 2003 17:36:12 -0800 (PST) (envelope-from sean@perrin.int.nxad.com) Received: by perrin.int.nxad.com (Postfix, from userid 1001) id 3D8CD2105B; Mon, 10 Mar 2003 17:35:46 -0800 (PST) Date: Mon, 10 Mar 2003 17:35:46 -0800 From: Sean Chittenden To: Giorgos Keramidas Cc: freebsd-doc@FreeBSD.org Subject: Re: Updated sendfile(2)... Message-ID: <20030311013546.GB79234@perrin.int.nxad.com> References: <20030310231907.GX79234@perrin.int.nxad.com> <20030310233805.GA7010@gothmog.gr> <20030311002406.GZ79234@perrin.int.nxad.com> <20030311012059.GA7701@gothmog.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030311012059.GA7701@gothmog.gr> User-Agent: Mutt/1.4i X-PGP-Key: finger seanc@FreeBSD.org X-PGP-Fingerprint: 3849 3760 1AFE 7B17 11A0 83A6 DD99 E31F BC84 B341 X-Web-Homepage: http://sean.chittenden.org/ Sender: owner-freebsd-doc@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org > > > > http://people.freebsd.org/~seanc/patches/#sendfile_2_tuning > > > > > > Seems ok. Just a few minor details that I noticed are shown below: > > > > Thanks for the style notes. Updated patch attached. -sc > > http://people.freebsd.org/~seanc/patches/#sendfile_2_tuning > > Looking at the source of uipc_syscalls.c I can quickly spot the part > that implements exactly the sort of behavior you describe. If > nobody else has comments on the content of the patch (i.e. someone > with more knowledge of the kernel internals), I say commit it :) Quite familiar with the problem and the internals in this area. Here's a patch for the problem: http://people.freebsd.org/~seanc/patches/patch-HEAD-src::sys::kern::uipc_syscalls.c And a description of the problem/fix: http://people.freebsd.org/~seanc/patches/#sendfile_no_block -sc -- Sean Chittenden To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message