From owner-freebsd-current@FreeBSD.ORG  Tue Jul  2 20:37:39 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id C28A1CD5
 for <freebsd-current@freebsd.org>; Tue,  2 Jul 2013 20:37:39 +0000 (UTC)
 (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com
 [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26])
 by mx1.freebsd.org (Postfix) with ESMTP id 88F0315CE
 for <freebsd-current@freebsd.org>; Tue,  2 Jul 2013 20:37:39 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7::dd0d:546b:1fe:6b39] (unknown
 [IPv6:2001:7b8:3a7:0:dd0d:546b:1fe:6b39])
 (using TLSv1 with cipher AES128-SHA (128/128 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id B70B15C43;
 Tue,  2 Jul 2013 22:37:36 +0200 (CEST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
Subject: Re: [PATCH] nvmecontrol breaks world
From: Dimitry Andric <dim@FreeBSD.org>
In-Reply-To: <CAJOYFBCWzzT7kSABROsyJsbt+N=KhQ3vmW4TJjw3Toxsxu836A@mail.gmail.com>
Date: Tue, 2 Jul 2013 22:37:35 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <7513EF4A-7808-4DC5-B60E-3AE93ECF85D1@FreeBSD.org>
References: <20130702201728.GA68544@troutmask.apl.washington.edu>
 <CAJOYFBCWzzT7kSABROsyJsbt+N=KhQ3vmW4TJjw3Toxsxu836A@mail.gmail.com>
To: Ed Schouten <ed@80386.nl>
X-Mailer: Apple Mail (2.1508)
Cc: FreeBSD Current <freebsd-current@freebsd.org>,
 Steve Kargl <sgk@troutmask.apl.washington.edu>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jul 2013 20:37:39 -0000

On Jul 2, 2013, at 22:30, Ed Schouten <ed@80386.nl> wrote:
> 2013/7/2 Steve Kargl <sgk@troutmask.apl.washington.edu>:
>> Could someone (this could even be me, but need approval) please
>> fix nvmecontrol?
>=20
> off_t doesn't need to be intmax_t, right? Maybe add an explicit cast?

Yes, that is what Bruce has suggested for off_t many times in the past. =
:-)


> Also, the call of malloc(sb.st_size) is not really safe...

Sure, but that does not break buildworld (for gcc users, I assume? the =
tinderboxes are all green).

-Dimitry