Date: Sat, 8 Jun 2002 07:39:14 -0700 From: "J. Mallett" <jmallett@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: Bruce Evans <bde@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/bin/ps extern.h Message-ID: <20020608073913.A89596@FreeBSD.ORG> In-Reply-To: <20020608225458.Q19691-100000@gamplex.bde.org>; from bde@zeta.org.au on Sat, Jun 08, 2002 at 11:13:53PM %2B1000 References: <20020608000108.A42463@FreeBSD.ORG> <20020608225458.Q19691-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* From Bruce Evans <bde@zeta.org.au> > > I think sorting by type makes no sense for extern declarations. (style.9 > only says how to sort structs and local variables. It says to sort > by size [largest first] (not type), then by name. Sorting struct members > by size gives better packing, and sorting local variables by size > (perhaps smallest instead of largest first) may give gives better packing > for primitive compilers, but extern declarations don't allocate space so > size considerations don't apply.) Okay. > > we should be sorting as per LANG=C, and in that case, 'ra' definitely comes a > > bit after 'no', however 'no' comes happily after 'nl', therefore the lines in > > this locate could be written as: > > > > %%% > > extern int cflag, eval, fscale, mempages, nlistread; > > extern time_t now; > > extern int rawcpu, sumrusage, termwidth, totwidth; > > %%% > > > > But I don't think revision 1.24 fixes unsorting. > > I didn't want to restructure the declarations to have only one variable > per line, so I followed my usual rule for insertion "sorting" in unsorted > list: insert before the first line whose first item is after the item > being inserted. Since this gave a very trivial change, I should have > restructured the declarations. Ah ha, okay. Thanks. -- J. Mallett <jmallett@FreeBSD.org> FreeBSD: The Power To Serve "I've coined new words, like, misunderstanding and Hispanically." -- George W. Bush, Radio-Television Correspondents Association dinner, Washington, D.C., March 29, 2001 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020608073913.A89596>