From owner-cvs-all Thu Mar 8 17:10:58 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (awfulhak.demon.co.uk [194.222.196.252]) by hub.freebsd.org (Postfix) with ESMTP id C615F37B718; Thu, 8 Mar 2001 17:10:52 -0800 (PST) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.2/8.11.2) with ESMTP id f291COC78546; Fri, 9 Mar 2001 01:12:24 GMT (envelope-from brian@lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.3/8.11.3) with ESMTP id f291DaN08582; Fri, 9 Mar 2001 01:13:36 GMT (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200103090113.f291DaN08582@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Brian Somers Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@Awfulhak.org Subject: Re: cvs commit: src/usr.sbin/ppp bundle.c ip.c ipcp.c physical.c prompt.c radius.c radius.h server.h systems.c In-Reply-To: Message from Brian Somers of "Thu, 08 Mar 2001 15:51:50 PST." <200103082351.f28Npou78229@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 09 Mar 2001 01:13:36 +0000 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > brian 2001/03/08 15:51:50 PST > > Modified files: > usr.sbin/ppp bundle.c ip.c ipcp.c physical.c prompt.c > radius.c radius.h server.h systems.c > Log: > MAXPATHLEN -> PATH_MAX > Don't assume MAXHOSTNAMELEN includes the NUL Hmm, as pointed out by Theo de Raadt, I now believe MAXHOSTNAMELEN *does* include the NUL. The code I've seen that thinks the extra +1 is required looks wrong: src/sys/netkey/key.c src/contrib/amd src/contrib/ipfilter src/contrib/traceroute src/usr.sbin/syslogd src/usr.sbin/traceroute6 src/usr.bin/netstat and of course (now) src/usr.sbin/ppp :-( I'll fix some of this tomorrow. -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message