From owner-freebsd-current@freebsd.org Fri Jun 23 10:44:21 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01AC0DA1AE1 for ; Fri, 23 Jun 2017 10:44:21 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: from mail-qk0-x22f.google.com (mail-qk0-x22f.google.com [IPv6:2607:f8b0:400d:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A31D280C47; Fri, 23 Jun 2017 10:44:20 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: by mail-qk0-x22f.google.com with SMTP id p21so32285700qke.3; Fri, 23 Jun 2017 03:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to; bh=Yo0zL/Dey/UMA2LXQsSkaUpbSu93pSwT5AR6Q3M80FU=; b=gezyPAEHivMjejCVrQ7NMPyYPNUMiG9g7V8N/WQH//NFRi52XYg7KRnO6RplJ7jJ/h ddHgRwQ/ztKbQHKdgobg12mBENY/TLItkYmPSun9RxDDnBbvCey2umH5pZGp5wXOvhQJ T7I6mam+A6lFr6QQE+dwoyLCnQdOfxh86CwLcZhmbVLY4YK1JtlRXnqO6waK1os7+zie o0LwMQQ0e4v2aXPRGmAfvA8Nc4407V1fPNd9wwIEBXDz3w3rRrbqo2qBRbXL+ASrsn2j BBgPkoYI19jUf6ae6nbsDfd9bprVQlCB3FflHJ/r3VlwUdJJfW7MDazp6eXwMAUBEnvE rfSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to; bh=Yo0zL/Dey/UMA2LXQsSkaUpbSu93pSwT5AR6Q3M80FU=; b=nGkpvf9Ky/S7ILIJ7YmMMXEaw3p5159nDoxucaTJzkSWYhCSyfvjOJzCz2NpKuEjB/ x2YBp6hon3OQyesn2UPzLq7WGo44HVZNNpmyZFp/ScqOwwTJbmuFSxNnblCUNC04G03L WTJjmIxPpsSLSidO00d0V0FUEsKsiiocUGlJ5ovALHcmDv5U1A2hGfVPCD+SS6enRE4z Mg5KVbTt3rHUrWmLH8LCdWepkB16PpqmIwTZHEFWgKHDv1zKhbQaalrYCnGvsudbPNJv SU+EZ0rZUgtTEYTHhVzW+z6FcdMVOFR4SF2fFv0EMs5SPcuo7J19N3p2wmYqSJSltcWP 6IlQ== X-Gm-Message-State: AKS2vOxojIwDF8W8LAaXbqWJ2XSQZaDKPQGTZOBG+i3DvYCRBNaQ5bCf J9mcmBSrWOPYYiwmdZw= X-Received: by 10.55.5.15 with SMTP id 15mr7705706qkf.39.1498214659402; Fri, 23 Jun 2017 03:44:19 -0700 (PDT) Received: from mbp-eth.home ([177.53.86.172]) by smtp.gmail.com with ESMTPSA id c143sm2902599qkg.64.2017.06.23.03.44.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jun 2017 03:44:17 -0700 (PDT) Sender: Renato Botelho Subject: Re: Failover Mode Between Ethernet and Wireless Interfaces broken on >= 11 To: Sean Bruno , freebsd-current@freebsd.org References: <1c1e5c6f-35e5-ca14-2e23-5e33d86a5266@FreeBSD.org> From: Renato Botelho Message-ID: <0e951324-7ec9-445d-06d0-64682cea6da4@FreeBSD.org> Date: Fri, 23 Jun 2017 07:44:13 -0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rKBIqeg5w2RCQi9mUmUOXGa5AP8rnEgKb" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2017 10:44:21 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rKBIqeg5w2RCQi9mUmUOXGa5AP8rnEgKb Content-Type: multipart/mixed; boundary="nk1Lqo5u7MdJSAulw8lPXhwWFO1MMJBXH"; protected-headers="v1" From: Renato Botelho To: Sean Bruno , freebsd-current@freebsd.org Message-ID: <0e951324-7ec9-445d-06d0-64682cea6da4@FreeBSD.org> Subject: Re: Failover Mode Between Ethernet and Wireless Interfaces broken on >= 11 References: <1c1e5c6f-35e5-ca14-2e23-5e33d86a5266@FreeBSD.org> In-Reply-To: --nk1Lqo5u7MdJSAulw8lPXhwWFO1MMJBXH Content-Type: multipart/mixed; boundary="------------F91B98396E255DFF847E4445" Content-Language: en-US This is a multi-part message in MIME format. --------------F91B98396E255DFF847E4445 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 21/06/17 16:26, Sean Bruno wrote: >=20 >=20 > On 06/21/17 11:48, Renato Botelho wrote: >> I've already sent it to net, but I suspect this is the appropriate pla= ce >> to discuss this subject. >> >> Last night I was configuring a new laptop and decided to give it [1] a= >> try. I figured out this section of handbook (similar instructions are = on >> lagg(4) manpage) is outdated, based on FreeBSD 10.x. >> >> Then I modified a bit the commands and tried to get it configured on >> 12-CURRENT, without success. I spoke with adrian@, who told me this >> setup doesn't work on FreeBSD > 10, because on newer versions Wireless= >> interfaces mac address cannot be changed. >> >> My next attempt was to do the other way round and make lagg to use wla= n0 >> mac address instead of em0's. but even doing this my wireless interfac= e >> ended up not working. >> >> After further investigation I noted that a simple command: >> >> # ifconfig wlan0 ether $wlan0_current_mac_address >> >> is enough to break it on 12-CURRENT. >> >> I've checked if_setlladdr() source code and noted it always replace th= e >> mac address, even if the same is already configured on the interface. = Is >> it the expected behavior? >> >> Just as a PoC I've applied the following patch to if_setlladdr(): >> >> Index: sys/net/if.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- sys/net/if.c (revision 320097) >> +++ sys/net/if.c (working copy) >> @@ -3519,6 +3519,10 @@ >> ifa_free(ifa); >> return (EINVAL); >> } >> + if (memcmp(lladdr, LLADDR(sdl), len) =3D=3D 0) { >> + ifa_free(ifa); >> + return (0); >> + } >> switch (ifp->if_type) { >> case IFT_ETHER: >> case IFT_FDDI: >> >> And configured it to use wlan0 mac address on rc.conf: >> >> ifconfig_em0=3D"ether 60:67:20:c5:2d:48 up" >> wlans_iwn0=3D"wlan0" >> ifconfig_wlan0=3D"WPA" >> cloned_interfaces=3D"lagg0" >> ifconfig_lagg0=3D"up laggproto failover laggport em0 laggport wlan0 DH= CP" >> >> and it's now working as expected. >> >> Other than that, I believe if wlan interfaces cannot have their mac >> address changed, ifconfig should return an error when user attempts to= >> do it, and if_setlladdr() should do the same. >> >> Thoughts? >> >> [1] >> https://www.freebsd.org/doc/handbook/network-aggregation.html#networki= ng-lagg-wired-and-wireless >> >=20 >=20 > Maybe this is a "iflib" problem. em(4) and igb(4) are pretty different= > now in head. Can you shove it into bugzilla with a test case > (copy/paste your email) and tag me on it? em0 is working as expected, the main problem is on iwn, which in my case = is: iwn0@pci0:3:0:0: class=3D0x028000 card=3D0x13118086 chip=3D0x00858086 rev= =3D0x34 hdr=3D0x00 vendor =3D 'Intel Corporation' device =3D 'Centrino Advanced-N 6205 [Taylor Peak]' class =3D network After investigate a bit more I noted wpa_supplicant is exiting when I change wlan0 mac address, and because of that my interface is disconnected. If I start wpa_supplicant again it back to work. # ifconfig wlan0 | grep status: status: associated # ifconfig wlan0 ether 60:67:20:c5:2d:49 # ifconfig wlan0 | grep status: status: no carrier # /etc/rc.d/wpa_supplicant restart wlan0 wpa_supplicant not running? (check /var/run/wpa_supplicant/wlan0.pid). Starting wpa_supplicant. # ifconfig wlan0 | grep status: status: associated It happens every time, even if I call ifconfig using the same mac address already configured. In this case, that patch I submitted on first email prevent the error to happen. Attached you can see wpa_supplicant log, my understanding is the relevant line is: 1498213478.949506: ioctl[SIOCS80211, op=3D20, val=3D0, arg_len=3D7]: Can'= t assign requested address --=20 Renato Botelho --------------F91B98396E255DFF847E4445 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="wpa_supplicant.log" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="wpa_supplicant.log" MTQ5ODIxMzQ3OC45NDkyNjU6IHdsYW4wOiBFdmVudCBESVNBU1NPQyAoMSkgcmVjZWl2ZWQK MTQ5ODIxMzQ3OC45NDkyOTE6IHdsYW4wOiBEaXNhc3NvY2lhdGlvbiBub3RpZmljYXRpb24K MTQ5ODIxMzQ3OC45NDkzMDg6IHdsYW4wOiBDVFJMLUVWRU5ULURJU0NPTk5FQ1RFRCBic3Np ZD01NjpkOTplNzo3NTozZjpiNiByZWFzb249MAoxNDk4MjEzNDc4Ljk0OTMyMTogd2xhbjA6 IEF1dG8gY29ubmVjdCBlbmFibGVkOiB0cnkgdG8gcmVjb25uZWN0ICh3cHM9MC8wIHdwYV9z dGF0ZT05KQoxNDk4MjEzNDc4Ljk0OTMzNTogd2xhbjA6IFNldHRpbmcgc2NhbiByZXF1ZXN0 OiAwLjEwMDAwMCBzZWMKMTQ5ODIxMzQ3OC45NDkzNjc6IEFkZGVkIEJTU0lEIDU2OmQ5OmU3 Ojc1OjNmOmI2IGludG8gYmxhY2tsaXN0CjE0OTgyMTM0NzguOTQ5MzgzOiB3bGFuMDogQmxh Y2tsaXN0IGNvdW50IDEgLS0+IHJlcXVlc3Qgc2NhbiBpbiAxMDAgbXMKMTQ5ODIxMzQ3OC45 NDkzOTU6IHdsYW4wOiBJZ25vcmUgbmV3IHNjYW4gcmVxdWVzdCBmb3IgMC4xMDAwMDAgc2Vj IHNpbmNlIGFuIGVhcmxpZXIgcmVxdWVzdCBpcyBzY2hlZHVsZWQgdG8gdHJpZ2dlciBzb29u ZXIKMTQ5ODIxMzQ3OC45NDk0MDg6IHdsYW4wOiBXUEE6IENsZWFyIG9sZCBQTUsgYW5kIFBU SwoxNDk4MjEzNDc4Ljk0OTQxNjogd2xhbjA6IERpc2Nvbm5lY3QgZXZlbnQgLSByZW1vdmUg a2V5cwoxNDk4MjEzNDc4Ljk0OTQyMjogYnNkX3NldF9rZXk6IGFsZz0wIGFkZHI9MHgwIGtl eV9pZHg9MCBzZXRfdHg9MCBzZXFfbGVuPTAga2V5X2xlbj0wCjE0OTgyMTM0NzguOTQ5NDMz OiBic2RfZGVsX2tleToga2V5X2lkeD0wCjE0OTgyMTM0NzguOTQ5NDYyOiBic2Rfc2V0X2tl eTogYWxnPTAgYWRkcj0weDAga2V5X2lkeD0xIHNldF90eD0wIHNlcV9sZW49MCBrZXlfbGVu PTAKMTQ5ODIxMzQ3OC45NDk0NzA6IGJzZF9kZWxfa2V5OiBrZXlfaWR4PTEKMTQ5ODIxMzQ3 OC45NDk0Nzk6IGJzZF9zZXRfa2V5OiBhbGc9MCBhZGRyPTB4ODAwNzM0MGYwIGtleV9pZHg9 MCBzZXRfdHg9MCBzZXFfbGVuPTAga2V5X2xlbj0wCjE0OTgyMTM0NzguOTQ5NDg1OiBic2Rf ZGVsX2tleTogYWRkcj01NjpkOTplNzo3NTozZjpiNgoxNDk4MjEzNDc4Ljk0OTUwNjogaW9j dGxbU0lPQ1M4MDIxMSwgb3A9MjAsIHZhbD0wLCBhcmdfbGVuPTddOiBDYW4ndCBhc3NpZ24g cmVxdWVzdGVkIGFkZHJlc3MKMTQ5ODIxMzQ3OC45NDk1MjE6IHdsYW4wOiBTdGF0ZTogQ09N UExFVEVEIC0+IERJU0NPTk5FQ1RFRAoxNDk4MjEzNDc4Ljk0OTUyOTogRUFQT0w6IEV4dGVy bmFsIG5vdGlmaWNhdGlvbiAtIHBvcnRFbmFibGVkPTAKMTQ5ODIxMzQ3OC45NDk1MzU6IEVB UE9MOiBTVVBQX1BBRSBlbnRlcmluZyBzdGF0ZSBESVNDT05ORUNURUQKMTQ5ODIxMzQ3OC45 NDk1NDI6IEVBUE9MOiBTdXBwbGljYW50IHBvcnQgc3RhdHVzOiBVbmF1dGhvcml6ZWQKMTQ5 ODIxMzQ3OC45NDk1NDc6IEVBUE9MOiBTVVBQX0JFIGVudGVyaW5nIHN0YXRlIElOSVRJQUxJ WkUKMTQ5ODIxMzQ3OC45NDk1NTU6IEVBUE9MOiBFeHRlcm5hbCBub3RpZmljYXRpb24gLSBw b3J0VmFsaWQ9MAoxNDk4MjEzNDc4Ljk0OTU2MDogRUFQT0w6IEV4dGVybmFsIG5vdGlmaWNh dGlvbiAtIEVBUCBzdWNjZXNzPTAKMTQ5ODIxMzQ3OC45NDk1Nzk6IFJUTV9JRklORk86IElu dGVyZmFjZSAnd2xhbjAnIERPV04KMTQ5ODIxMzQ3OC45NDk1OTg6IHdsYW4wOiBFdmVudCBJ TlRFUkZBQ0VfU1RBVFVTICg1KSByZWNlaXZlZAoxNDk4MjEzNDc4Ljk0OTYxMDogd2xhbjA6 IENvbmZpZ3VyZWQgaW50ZXJmYWNlIHdhcyByZW1vdmVkCjE0OTgyMTM0NzguOTQ5NjE5OiB3 bGFuMDogU3RhdGU6IERJU0NPTk5FQ1RFRCAtPiBESVNDT05ORUNURUQKMTQ5ODIxMzQ3OC45 NDk2MjQ6IEVBUE9MOiBFeHRlcm5hbCBub3RpZmljYXRpb24gLSBwb3J0RW5hYmxlZD0wCjE0 OTgyMTM0NzguOTQ5NjI5OiBFQVBPTDogRXh0ZXJuYWwgbm90aWZpY2F0aW9uIC0gcG9ydFZh bGlkPTAKMTQ5ODIxMzQ3OC45NDk2Mzk6IHdsYW4wOiBTdGF0ZTogRElTQ09OTkVDVEVEIC0+ IElOVEVSRkFDRV9ESVNBQkxFRAoxNDk4MjEzNDc4Ljk0OTkyMzogd2xhbjA6IFJlbW92aW5n IGludGVyZmFjZSB3bGFuMAoxNDk4MjEzNDc4Ljk0OTk0OTogd2xhbjA6IFJlcXVlc3QgdG8g ZGVhdXRoZW50aWNhdGUgLSBic3NpZD0wMDowMDowMDowMDowMDowMCBwZW5kaW5nX2Jzc2lk PTAwOjAwOjAwOjAwOjAwOjAwIHJlYXNvbj0zIHN0YXRlPUlOVEVSRkFDRV9ESVNBQkxFRAox NDk4MjEzNDc4Ljk0OTk1Nzogd3BhX2RyaXZlcl9ic2Rfc2V0X2NvdW50ZXJtZWFzdXJlczog ZW5hYmxlZD0wCjE0OTgyMTM0NzguOTUxNzcyOiB3bGFuMDogV1BBOiBDbGVhciBvbGQgUE1L IGFuZCBQVEsKMTQ5ODIxMzQ3OC45NTE4MDE6IFJlbW92ZWQgQlNTSUQgNTY6ZDk6ZTc6NzU6 M2Y6YjYgZnJvbSBibGFja2xpc3QgKGNsZWFyKQoxNDk4MjEzNDc4Ljk1MTgzMDogd2xhbjA6 IEJTUzogUmVtb3ZlIGlkIDAgQlNTSUQgNDY6ZDk6ZTc6NzU6M2Y6YjYgU1NJRCAnQW5nYmFu ZCcgZHVlIHRvIHdwYV9ic3NfZmx1c2gKMTQ5ODIxMzQ3OC45NTE4NTc6IHdsYW4wOiBCU1M6 IFJlbW92ZSBpZCAxIEJTU0lEIDZhOjAyOjcxOjcyOjVmOjA0IFNTSUQgJ0Rlc2t0b3BfRjdB NDEzNDEnIGR1ZSB0byB3cGFfYnNzX2ZsdXNoCjE0OTgyMTM0NzguOTUxODc4OiB3bGFuMDog QlNTOiBSZW1vdmUgaWQgMiBCU1NJRCA1NjpkOTplNzo3NTozZjpiNiBTU0lEICdNT1JET1In IGR1ZSB0byB3cGFfYnNzX2ZsdXNoCjE0OTgyMTM0NzguOTUxOTE1OiB3bGFuMDogQlNTOiBS ZW1vdmUgaWQgMyBCU1NJRCBjNDo2ZToxZjo2OTphMTo1NiBTU0lEICdWYWxmZW5kYScgZHVl IHRvIHdwYV9ic3NfZmx1c2gKMTQ5ODIxMzQ3OC45NTE5NDA6IHdsYW4wOiBCU1M6IFJlbW92 ZSBpZCA0IEJTU0lEIDZhOjAyOjcxOjU5OmNlOmY3IFNTSUQgJ0Rlc2t0b3BfRjNBNDgzMTgn IGR1ZSB0byB3cGFfYnNzX2ZsdXNoCjE0OTgyMTM0NzguOTUxOTYwOiB3bGFuMDogQ2FuY2Vs bGluZyBzY2FuIHJlcXVlc3QKMTQ5ODIxMzQ3OC45NTE5NzI6IHdsYW4wOiBDYW5jZWxsaW5n IGF1dGhlbnRpY2F0aW9uIHRpbWVvdXQKMTQ5ODIxMzQ3OC45NTE5ODk6IFJlbW92ZSBpbnRl cmZhY2Ugd2xhbjAgZnJvbSByYWRpbwoxNDk4MjEzNDc4Ljk1MTk5NzogUmVtb3ZlIHJhZGlv CjE0OTgyMTM0NzguOTUyMDA0OiB3cGFfZHJpdmVyX2JzZF9zZXRfd3BhOiBlbmFibGVkPTAK MTQ5ODIxMzQ3OC45NTIwMTE6IHdwYV9kcml2ZXJfYnNkX3NldF93cGFfaW50ZXJuYWw6IHdw YT0wIHByaXZhY3k9MAoxNDk4MjEzNDc4Ljk1MjAxODogYnNkX3NldF9vcHRfaWU6IHNldCBX UEErUlNOIGllIChsZW4gMCkKMTQ5ODIxMzQ3OC45OTY4ODU6IHdwYV9kcml2ZXJfYnNkX3Nl dF93cGFfaW50ZXJuYWw6IHdwYT0wIHByaXZhY3k9MAoxNDk4MjEzNDc4Ljk5NjkxMjogYnNk X3NldF9vcHRfaWU6IHNldCBXUEErUlNOIGllIChsZW4gMCkKMTQ5ODIxMzQ3OC45OTY5Njg6 IHdsYW4wOiBDVFJMLUVWRU5ULVRFUk1JTkFUSU5HCg== --------------F91B98396E255DFF847E4445-- --nk1Lqo5u7MdJSAulw8lPXhwWFO1MMJBXH-- --rKBIqeg5w2RCQi9mUmUOXGa5AP8rnEgKb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iQIcBAEBCgAGBQJZTPD+AAoJEPHw56GfYleQ94kP/iOW5bVShd5s2hV5erHZsryf gE1lKTRLx9cRLwXva3QDygrhdJk7z50rR20n4fkVbktsvGo8fBPZn+xeFmQNjpff TK8WAW8WbdpLr1bW8Ki3lE6VAFGqn7AAtF6KXOLByzPILZ21oMBIhad89NvjrHHX gaq1hDdDOiFtXJ9yLGdFsP4MR86eO6mqKc/yTeyfQJeSnU3TPCVly8eoAim88Txl c5Dfsz02NesBl3YGWWviq518FDyidk9c0xKBpI4OG5YXJsoMD/z7LMfHO2Hdqc0Q TFIXJ+vhJ4hhLSPcwnEZiqWwaGoZMjs7PE+P9wGeRB3cNk1u6JwNS+KRvy6S/W7g ncWGFFOSjqT0abPCxfoLgSEvnEGFJaZbBsOCvI192edIFm7UcS5o9AKavbG29rwU tjfBf+8g9xpkVwvlzeMl2kVcXKHGvGfpi5i+6gPpD9B4eNRVI5PiQf9TqIC1y7Sf gdSmqffR0kpfPpDBIBLXUckbfHkVYMussm4NFeXTqXxESNWHuZatUGn0ooE4b84y 3bSUhAlD/xk46bF54JFN4CucDnXE9V1I1un8zcbBoaZPkDXa6rGjP8SQ8kx2fIEC OIuGNqdjLDEOtSGIS8uPdQzCynPtGYp1PK/QUvD6xw9riDGc1ZQdcW8GLfiynvR2 cjsX/XDq6MBmvnpnqwaL =6OhG -----END PGP SIGNATURE----- --rKBIqeg5w2RCQi9mUmUOXGa5AP8rnEgKb--