From owner-cvs-all  Sun Jun 23 13:21:27 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5])
	by hub.freebsd.org (Postfix) with ESMTP
	id DF46837B40E; Sun, 23 Jun 2002 13:20:54 -0700 (PDT)
Received: from hades.hell.gr (patr530-b214.otenet.gr [212.205.244.222])
	by mailsrv.otenet.gr (8.12.3/8.12.3) with ESMTP id g5NKKnFr017988;
	Sun, 23 Jun 2002 23:20:50 +0300 (EEST)
Received: from hades.hell.gr (hades [127.0.0.1])
	by hades.hell.gr (8.12.4/8.12.4) with ESMTP id g5NKKmIm047334;
	Sun, 23 Jun 2002 23:20:48 +0300 (EEST)
	(envelope-from keramida@ceid.upatras.gr)
Received: (from charon@localhost)
	by hades.hell.gr (8.12.4/8.12.4/Submit) id g5NKDCQ9046581;
	Sun, 23 Jun 2002 23:13:12 +0300 (EEST)
	(envelope-from keramida@ceid.upatras.gr)
Date: Sun, 23 Jun 2002 23:13:11 +0300
From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: Kris Kennaway <kris@obsecurity.org>
Cc: John Polstra <jdp@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG,
	cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/i386/i386 in_cksum.c src/sys/i386/include in_cksum.h
Message-ID: <20020623201311.GB36974@hades.hell.gr>
References: <200206222235.g5MMZrd58098@freefall.freebsd.org> <20020622212912.A42681@xor.obsecurity.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020622212912.A42681@xor.obsecurity.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On 2002-06-22 21:29 +0000, Kris Kennaway wrote:
> On Sat, Jun 22, 2002 at 03:35:53PM -0700, John Polstra wrote:
> > jdp         2002/06/22 15:35:53 PDT
> >
> >   Modified files:
> >     sys/i386/i386        in_cksum.c
> >     sys/i386/include     in_cksum.h
> >   Log:
> >   Fix several bugs in the i386 asm statements used to speed up Internet
> >   checksumming.  These bugs could possibly cause bad code to be
> >   generated at elevated optimization levels.
>
> I'm pretty sure I've seen this bug in action with -O2 kernels (years
> ago) - good catch!

I've seen checksums work fine with -O but somehow fail (giving a
checksum value of 0xfffe in tcpdump output) when -O2 or anything
higher is used.

Definitely a very good piece of work!

- Giorgos


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message