Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Sep 2014 20:16:33 +0400
From:      Andrey Chernov <ache@freebsd.org>
To:        Alexander Motin <mav@FreeBSD.org>, src-committers@freebsd.org,  svn-src-all@freebsd.org, svn-src-stable@freebsd.org,  svn-src-stable-10@freebsd.org
Subject:   Re: svn commit: r271707 - stable/10/sys/kern
Message-ID:  <5419B3E1.1090703@freebsd.org>
In-Reply-To: <201409171406.s8HE6LNu071461@svn.freebsd.org>
References:  <201409171406.s8HE6LNu071461@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 17.09.2014 18:06, Alexander Motin wrote:
> +	/*
> +	 * Make sure that tdq_load updated before calling this function
> +	 * is globally visible before we read tdq_cpu_idle.  Idle thread
> +	 * accesses both of them without locks, and the order is important.
> +	 */
> +	mb();
> +
>  	if (TD_IS_IDLETHREAD(ctd)) {

I don't understand this comment's first phrase with two verbs. Copy &
paste result?
I also don't see tdq_load access in this function.

-- 
http://ache.vniz.net/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5419B3E1.1090703>