From owner-svn-src-all@FreeBSD.ORG  Sun Sep 16 15:09:21 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 260E1106564A;
	Sun, 16 Sep 2012 15:09:21 +0000 (UTC)
	(envelope-from mdf356@gmail.com)
Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com
	[209.85.160.54])
	by mx1.freebsd.org (Postfix) with ESMTP id CCB618FC08;
	Sun, 16 Sep 2012 15:09:20 +0000 (UTC)
Received: by pbbrp2 with SMTP id rp2so8522752pbb.13
	for <multiple recipients>; Sun, 16 Sep 2012 08:09:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=eR7xCxIQ5sh/Rt8TZMgkcOCnQtBfoqQZO5epbgfr1JI=;
	b=J0pP9dD/FaJukx0UoHtOBvrc41ZvrKnxUPkfkzqg9999NCo7oN6lUqu2SwKkhcmOeI
	7+wngUBy8CBAPrJCy+/IYJ0mV+em467XKJ8xcyFcB8+a2G3IDWesPqAlM/wFnFGZpiZt
	UZ124x4Qb0e9TojEI07rJND5S8GAnVvIl0vbZHbVZXze1YXltKqknaENwXy7o8HGREQZ
	Eqyah/Omj6ZIfya26HQoRK6W9T35mbEO5mDUObFC/4tJxsbwkj4zvsokWk98csJPlKwZ
	eLbnq/p/rVmWuKVD3Qhr6Uou5m9stkuHK4iuOMoozTovJ5FfV3XL548iKZ4GNKq0pzoA
	JI6w==
MIME-Version: 1.0
Received: by 10.68.234.98 with SMTP id ud2mr16323522pbc.165.1347808160307;
	Sun, 16 Sep 2012 08:09:20 -0700 (PDT)
Sender: mdf356@gmail.com
Received: by 10.68.13.170 with HTTP; Sun, 16 Sep 2012 08:09:20 -0700 (PDT)
In-Reply-To: <20120916095355.GA83285@FreeBSD.org>
References: <201209160755.q8G7tnMH036332@svn.freebsd.org>
	<20120916092818.GA81952@FreeBSD.org>
	<CADLo83-5zQBdf3ndBXO4qbkXJgaFPxGfE86LSDGqJ4g3k_4gkw@mail.gmail.com>
	<20120916095355.GA83285@FreeBSD.org>
Date: Sun, 16 Sep 2012 08:09:20 -0700
X-Google-Sender-Auth: gwBE-1mTUzcmWupgK6iDOU54sj4
Message-ID: <CAMBSHm_6YAQeLAgXm4mu5mT76T1irfmQdWx=PVfOx+5ihLnksQ@mail.gmail.com>
From: mdf@FreeBSD.org
To: Alexey Dokuchaev <danfe@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: Chris Rees <crees@freebsd.org>, Andrew Turner <andrew@freebsd.org>,
	svn-src-all@freebsd.org, src-committers@freebsd.org,
	svn-src-head@freebsd.org
Subject: Re: svn commit: r240549 - head/sys/arm/tegra
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Sep 2012 15:09:21 -0000

On Sun, Sep 16, 2012 at 2:53 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Sun, Sep 16, 2012 at 10:37:56AM +0100, Chris Rees wrote:
>> On 16 September 2012 10:28, Alexey Dokuchaev <danfe@freebsd.org> wrote:
>> > I thought preferred and more style(9) compliant way to code [empty
>> > endless loop] is:
>> >
>> >         for (;;)
>> >                 continue;
>>
>> Actually:
>>
>> for (;;)
>>         ;
>
> Explicit "continue" is supposed to tell reviewer that original author did
> not make a typo, but indeed knew what he was doing.  Lonely semicolon is too
> ambiguous in this case.

The semicolon being on its own line is not ambiguous, and is good
style everywhere.  A semicolon on the same line as a while or for is a
red flag that it may be unintentional.

Cheers,
matthew