From owner-svn-src-all@freebsd.org Tue Mar 7 09:29:24 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 566EDD00A3A; Tue, 7 Mar 2017 09:29:24 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 18B321D64; Tue, 7 Mar 2017 09:29:24 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1clBQo-0003IB-6e; Tue, 07 Mar 2017 12:29:22 +0300 Date: Tue, 7 Mar 2017 12:29:22 +0300 From: Slawa Olhovchenkov To: Andriy Gapon Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r314274 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <20170307092922.GZ70430@zxy.spb.ru> References: <201702251703.v1PH3nQd044474@repo.freebsd.org> <20170307035308.GN15630@zxy.spb.ru> <20170307091818.GY70430@zxy.spb.ru> <5e1fa060-719e-4677-164a-856e3f6c779f@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e1fa060-719e-4677-164a-856e3f6c779f@FreeBSD.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 09:29:24 -0000 On Tue, Mar 07, 2017 at 11:24:42AM +0200, Andriy Gapon wrote: > On 07/03/2017 11:18, Slawa Olhovchenkov wrote: > > On Tue, Mar 07, 2017 at 11:02:46AM +0200, Andriy Gapon wrote: > > > >> On 07/03/2017 05:53, Slawa Olhovchenkov wrote: > >>> On Sat, Feb 25, 2017 at 05:03:49PM +0000, Andriy Gapon wrote: > >>> > >>>> Author: avg > >>>> Date: Sat Feb 25 17:03:48 2017 > >>>> New Revision: 314274 > >>>> URL: https://svnweb.freebsd.org/changeset/base/314274 > >>>> > >>>> Log: > >>>> l2arc: try to fix write size calculation broken by Compressed ARC commit > >>>> > >>>> While there, make a change to not evict a first buffer outside the > >>>> requested eviciton range. > >>>> > >>>> To do: > >>>> - give more consistent names to the size variables > >>>> - upstream to OpenZFS > >>> > >>> Mem: 6647M Active, 8399M Inact, 87G Wired, 49K Buf, 23G Free > >>> ^^^^^^^^^ > >>> ARC: 130G Total, 255M MFU, 80G MRU, 267M Anon, 72M Header, 41M Other > >>> ^^^^^ > >>> > >>> 128GB phys mem > >>> > >> > >> Why this commit? > > > > revert this commit and r307265 resolve this. > > i.e. may be r307265, but r307265 related to this. > > So, why not comment on r307265 or bisect first? You are kidding?! How to work this commit w/o r307265? r307265 is l2arc compression suport (buggly). this commit fix l2arc part. arc part still buggly. hmm, may be I am not clean, I am not rever ALL to r307265. I am rever exact r307265 and 314274. This is like bisect by one try.