From owner-svn-src-all@FreeBSD.ORG Thu May 5 14:05:23 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F3DB106564A; Thu, 5 May 2011 14:05:23 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-jnhn.mail.uoguelph.ca (esa-jnhn.mail.uoguelph.ca [131.104.91.44]) by mx1.freebsd.org (Postfix) with ESMTP id 6DD538FC18; Thu, 5 May 2011 14:05:21 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApwEAH2twk2DaFvO/2dsb2JhbACEUKJdtCqRL4EqhF0Ej0qHGodR X-IronPort-AV: E=Sophos;i="4.64,319,1301889600"; d="scan'208";a="121337347" Received: from erie.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.206]) by esa-jnhn-pri.mail.uoguelph.ca with ESMTP; 05 May 2011 09:54:13 -0400 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id 47929B3F2B; Thu, 5 May 2011 09:54:13 -0400 (EDT) Date: Thu, 5 May 2011 09:54:13 -0400 (EDT) From: Rick Macklem To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= Message-ID: <942285768.1045464.1304603653229.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <86r58dsi0m.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [172.17.91.201] X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - IE7 (Win)/6.0.10_GA_2692) Cc: svn-src-head@freebsd.org, Rick Macklem , svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221124 - in head: . sbin/mount sbin/mount_nfs sys/amd64/conf sys/fs/nfsclient sys/i386/conf sys/ia64/conf sys/nfsclient sys/pc98/conf sys/powerpc/conf sys/sparc64/conf sys/sun4v/conf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2011 14:05:23 -0000 > Rick Macklem writes: > > "Dag-Erling Sm=C3=B8rgrav" writes: > > > Ideally, both the old and the new NFS stack would use the same > > > fstypes and sysctl names, but I don't know if there's any way we > > > can > > > prevent someone from compiling both into the kernel at the same > > > time, or loading both modules. > > If the scripts in /etc/rc.d are fixed to use the correct sysctl > > naming, > > do you think it matters which one is "vfs.nfs."? >=20 > Yes. There is a whole world outside the base system: munin, webmin, > nagios etc. Are you going to change all of them as well? >=20 Well, another way it could be handled would be to put the sysctls and the global variables they manipulate in a module shared by both clients, like sys/nfs/nfs_lock.c (module "nfslock"). Then the same sysctl would affect both clients. (I hesitate to create "yet another" module just to share the sysctls, but since "nfslock" is used by both clients, it should work ok, I think.) What do you think of that? If anyone else reading this has an idea/opinion, please let us know. rick