From owner-freebsd-current@FreeBSD.ORG Mon Sep 8 02:56:25 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 355E1F09; Mon, 8 Sep 2014 02:56:25 +0000 (UTC) Received: from mail-qa0-x22a.google.com (mail-qa0-x22a.google.com [IPv6:2607:f8b0:400d:c00::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DA19A1DE7; Mon, 8 Sep 2014 02:56:24 +0000 (UTC) Received: by mail-qa0-f42.google.com with SMTP id dc16so9508850qab.1 for ; Sun, 07 Sep 2014 19:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=azzVFKWz4bugHg1z8jBN9P9JIY64imjrFXBs4xfhYL4=; b=ZzjoUwojumRGFhClzIJOPFZdvWKahWMAahrCRwVvOxlL4lzKq4zaZ1Q2ObQ7afyEOs lUudsBKgut9OfOtJ8xGetNWeG1Ns2ELUMtR5tXvj1TRyw18GwYwe3HXlNWQcDqYj+ZQa 5YrFGbfxsqWbNyEW1FbaEjy29QfcxofNrY4X258PzOnkPt+b2Fxim0vNZdMwntNfHdQB Q0VJec0WBJisWTeHzmuBlA7yIrP7UNfiF9qAsP3X5N22w7IM9yICYr3FO6LJZbfp5juA eLxIxJrYSXlbN16WH2AM1YM7hnBSIsCXv7r7ABDIFYqERKd3qzLgBWuphYA2Ecd6M6kj hUyw== MIME-Version: 1.0 X-Received: by 10.140.31.75 with SMTP id e69mr36324863qge.2.1410144983941; Sun, 07 Sep 2014 19:56:23 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.39.139 with HTTP; Sun, 7 Sep 2014 19:56:23 -0700 (PDT) In-Reply-To: <20140908023425.GF48287@hub.FreeBSD.org> References: <1410123815.10027.18.camel@bruno> <20140907210802.GA48287@hub.FreeBSD.org> <20140908023425.GF48287@hub.FreeBSD.org> Date: Sun, 7 Sep 2014 19:56:23 -0700 X-Google-Sender-Auth: aOaJmBkyMpvt8Vv46DKX66mSccg Message-ID: Subject: Re: NO INET6 warning From: Adrian Chadd To: Glen Barber Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current , Garrett Cooper X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2014 02:56:25 -0000 No, because I may end up building a kernel that has no INET6 for a cut down platform that has no src.conf option set. -a On 7 September 2014 19:34, Glen Barber wrote: > On Sun, Sep 07, 2014 at 03:34:35PM -0700, yaneurabeya@gmail.com wrote: >> On Sep 7, 2014, at 14:08, Glen Barber wrote: >> >> > On Sun, Sep 07, 2014 at 02:03:35PM -0700, Sean Bruno wrote: >> >> make[4]: "/home/sbruno/bsd/fbsd_head/sys/modules/if_gif/Makefile" lin= e >> >> 12: warning: Couldn't read shell's output for >> >> "cat /home/sbruno/bsd/obj/mips/mips.mips/home/sbruno/bsd/fbsd_head/sy= s/WZR-300HP/opt_inet6.h" >> >> >> >> >> >> Shouldn't this cat be done in a saner way? >> >> >> > >> > This is done quite often throughout the tree, and bmake(1) does not li= ke >> > it when there is no value assigned from the '!=3D' expansion. >> > >> > The fix I've seen most commonly done is to echo a newline after the >> > assignment, such as: >> > >> > Index: sys/modules/if_gif/Makefile >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> > --- sys/modules/if_gif/Makefile (revision 271215) >> > +++ sys/modules/if_gif/Makefile (working copy) >> > @@ -9,7 +9,7 @@ KMOD=3D if_gif >> > SRCS=3D if_gif.c in_gif.c opt_inet.h opt_inet6.h opt_mrouting.h >> > >> > .if defined(KERNBUILDDIR) >> > -OPT_INET6!=3D cat ${KERNBUILDDIR}/opt_inet6.h >> > +OPT_INET6!=3D cat ${KERNBUILDDIR}/opt_inet6.h; echo >> > .if empty(OPT_INET6) >> > MK_INET6_SUPPORT=3Dno >> > .endif >> >> Shouldn=E2=80=99t this all be removed and replaced with equivalent logic= provided by kern.opts.mk? > > Probably. > > Glen >