From owner-svn-src-head@FreeBSD.ORG Fri May 29 12:33:00 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8EE5B106567A; Fri, 29 May 2009 12:33:00 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 625C18FC0C; Fri, 29 May 2009 12:33:00 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id B0A9F46B06; Fri, 29 May 2009 08:32:59 -0400 (EDT) Date: Fri, 29 May 2009 13:32:59 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Attilio Rao In-Reply-To: <3bbf2fe10905290457k7a00616dj43fc67a75d4a12b7@mail.gmail.com> Message-ID: References: <200905291052.n4TAqc5q072775@svn.freebsd.org> <3bbf2fe10905290457k7a00616dj43fc67a75d4a12b7@mail.gmail.com> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r193030 - in head: share/man/man9 sys/kern sys/net sys/security/mac sys/sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2009 12:33:01 -0000 On Fri, 29 May 2009, Attilio Rao wrote: >> Make the rmlock(9) interface a bit more like the rwlock(9) interface: >> >> - Add rm_init_flags() and accept extended options only for that variation. >> - Add a flags space specifically for rm_init_flags(), rather than borrowing >> the lock_init() flag space. >> - Define flag RM_RECURSE to use instead of LO_RECURSABLE. >> - Define flag RM_NOWITNESS to allow an rmlock to be exempt from WITNESS >> checking; this wasn't possible previously as rm_init() always passed >> LO_WITNESS when initializing an rmlock's struct lock. >> - Add RM_SYSINIT_FLAGS(). >> - Rename embedded mutex in rmlocks to make it more obvious what it is. >> - Update consumers. >> - Update man page. > > Thanks! There's quite a bit more to be done with rmlocks -- among other things, lock assertion support is quite incomplete, and it needs to integrate with WITNESS better. I probably don't have time to work on this, but perhaps for someone with a bit more experience with our locking primitives it would prove straight forward? :-) Robert N M Watson Computer Laboratory University of Cambridge