From nobody Sun Jul 13 00:56:51 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bfn8j6Y09z61PjJ; Sun, 13 Jul 2025 00:56:53 +0000 (UTC) (envelope-from ahmadkhalifa570@gmail.com) Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bfn8j44nsz3QsN; Sun, 13 Jul 2025 00:56:53 +0000 (UTC) (envelope-from ahmadkhalifa570@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-710f39f5cb9so28685657b3.3; Sat, 12 Jul 2025 17:56:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752368211; x=1752973011; darn=freebsd.org; h=cc:to:subject:message-id:date:in-reply-to:references:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=foGUA38DdNrv5h+SBwYtFpCiYdG1chqR/Kv/rGmdyWo=; b=mKoBHe2Nb4vzPaaYFHO+pRG3EAyn+24q7rpWEvABRpksB+l8ym3bUOZVBNGT/C5TpH eQTOabaPPTqZhZoSS8mhFrjTrqJUkqP5pZqus0USMrtAGHFJfEjQ6lQa61AHE0Jwg4N4 HIXiCsw3o2JHyXjSM9eAf/H4Sil6k7DAKUQQY8pD+RoqHYGfIctmeP2mupsKdw0Nkkcx UfD2YUitV4fi08Nv/QoQR0/i44iiKnElkfNHUmp0ChSyf8yoYGQlh8pmr47zxfvGogNZ cHzqPmxo45kBewYjkf6CR5YdBRHOEwDc44kF+ca6fdG1MTZixtANrtp9n8gleGodiJnP 6TYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752368211; x=1752973011; h=cc:to:subject:message-id:date:in-reply-to:references:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=foGUA38DdNrv5h+SBwYtFpCiYdG1chqR/Kv/rGmdyWo=; b=F33SfiT641iyaF2hqX+ukLP1SnJy5k7z4voytCTkZWdeEPxpX5GwhcsqC9L3jvA1XO +YlsywcuL0QpzA/KI8jeLj5pndKdBTl0UbSOFkfDFqwaQMROjcGBLhVZ+UbV6WEPoy0/ v8tRrWwOEOET7dDl2/x2FttxoP4u+tZoU2WgbNlWOKvQ0K3UVYHMjshADj6U3v79/2eA KUYrqRs5NHaTy6YOEjdQbeS8HQgETaQW2rds0uswGM/KI8DF+F8TdPaoZnsqu1RQH/YX nY0/Jt6wanZMu+Mk0ea37c+IoKqvBKYPHhAw0osQukszUacSWWfV1rCdRxMXXIaZkVbb l2/Q== X-Forwarded-Encrypted: i=1; AJvYcCUEPjc1DwKMG+SO+BwJo+7QSNH6QGTG5dlzC7f7jxdwV+s6+3G5F043Qe0wpBWGvuw8rzovLU9AFCXlX7Wv6o7NiAMe@freebsd.org, AJvYcCUz+8grzDDrdY/9b5+DJXuCN233cw3lP7RLDMNnWhiNCvNPCwORxsRlCPziuWoTWn2HGO8jN4njS5egnE/loA0=@freebsd.org, AJvYcCWmBShpI47aZraGYI6XNqY10FK4UbNgbBfx2Uw4+9t4VHYDnNiDhDmue249CUuBLSmnGKERjmUwpij/YFMrRMTC47+9ehU=@freebsd.org X-Gm-Message-State: AOJu0Yw+yhNVYqrlZ3J0lEUBNp9fVenpGxIitnkc1os3+dXwYOiJvd+y /QtTHc9Gi4yZrPgH9JOLpnRz8C90b12gNZvetEVTflVWYv1ATDItq82GWK9InmzOM27vy8J94zs 2kbUKPHTddfwRFta3cRSOKKX/9aQ5mQbqGg== X-Gm-Gg: ASbGncuAtu0yD4sbj1uEClzraGp8VBROITfyJuSu5/armoHveQGP5Cw3mn4k/f8sBHS lyVl5ab0fOkd3qK8dFUWDdu1XJRbh50DcQXM9sI6VozxsyXF4E6GB9rfodI1Gz2vRjdAFZ0eX+v IbQqGC32Yl7vBPHm4PJQeW7DR8RVaN7JvYDt5W0dKBtlNlgrVjSnwOscL0jx+foqRbZ3aVIwxy3 uWRBlBS X-Google-Smtp-Source: AGHT+IHAbVBju5zC97ECCDZfsMSy8sYhYwEu1IOFJ3n7akVqXe6TMyzuJMcSED8kF7Y6zu7EzvMkteTZ7gn/vdtNe5o= X-Received: by 2002:a05:690c:55c3:10b0:714:31:c9c6 with SMTP id 00721157ae682-717db2b04b7mr75488477b3.30.1752368211567; Sat, 12 Jul 2025 17:56:51 -0700 (PDT) Received: from 490177373942 named unknown by gmailapi.google.com with HTTPREST; Sun, 13 Jul 2025 00:56:51 +0000 Received: from 490177373942 named unknown by gmailapi.google.com with HTTPREST; Sun, 13 Jul 2025 00:56:51 +0000 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 From: Ahmad Khalifa X-Mailer: aerc 0.20.1 References: <202507121757.56CHv2Vi075595@gitrepo.freebsd.org> In-Reply-To: <202507121757.56CHv2Vi075595@gitrepo.freebsd.org> Date: Sun, 13 Jul 2025 00:56:51 +0000 X-Gm-Features: Ac12FXzE203uMRhcsVh7gBMbJY7CmVnb1y5t_lZZUpbv-6SVzZMwwOXMArPy2s8 Message-ID: Subject: Re: git: fb84b9f400d2 - main - kern_descrip.c: only allow complex expression in Static_assert() for clang To: Konstantin Belousov Cc: jhb@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4bfn8j44nsz3QsN X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] On Sat Jul 12, 2025 at 8:57 PM +0300, Konstantin Belousov wrote: > The branch main has been updated by kib: > > URL: https://cgit.FreeBSD.org/src/commit/?id=fb84b9f400d2d2bb8e1336fbacc7fbd14d31974b > > commit fb84b9f400d2d2bb8e1336fbacc7fbd14d31974b > Author: Konstantin Belousov > AuthorDate: 2025-07-11 18:57:32 +0000 > Commit: Konstantin Belousov > CommitDate: 2025-07-12 17:56:13 +0000 > > kern_descrip.c: only allow complex expression in Static_assert() for clang > > gcc cannot compute the assert expression, which is formally not required > by a C standard. > > Reported and reviewed by: jhb > Sponsored by: The FreeBSD Foundation > --- > sys/kern/kern_descrip.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sys/kern/kern_descrip.c b/sys/kern/kern_descrip.c > index 93bdd41d1515..c4f5e586b0ed 100644 > --- a/sys/kern/kern_descrip.c > +++ b/sys/kern/kern_descrip.c > @@ -557,8 +557,10 @@ open_to_fde_flags(int open_flags, bool sticky_orb) > { .f = O_CLOFORK, .t = UF_FOCLOSE }, > { .f = O_RESOLVE_BENEATH, .t = UF_RESOLVE_BENEATH }, > }; > +#ifdef __clang__ > _Static_assert(open_to_fde_flags_s[nitems(open_to_fde_flags_s) - 1].f == > O_RESOLVE_BENEATH, "O_RESOLVE_BENEATH must be last, for sticky_orb"); > +#endif > > return (flags_trans(open_to_fde_flags_s, nitems(open_to_fde_flags_s) - > (sticky_orb ? 0 : 1), open_flags)); This doesn't compile on clang14 when cross-building do we still care about that? See https://github.com/freebsd/freebsd-src/actions/runs/16240751228/job/45856816666