From owner-svn-src-all@FreeBSD.ORG Thu May 6 17:26:55 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3E1891065678; Thu, 6 May 2010 17:26:55 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [211.166.10.233]) by mx1.freebsd.org (Postfix) with ESMTP id 8E3188FC13; Thu, 6 May 2010 17:26:54 +0000 (UTC) Received: from mail.geekcn.org (tarsier.geekcn.org [211.166.10.233]) by tarsier.geekcn.org (Postfix) with ESMTP id 7C794A69503; Fri, 7 May 2010 01:10:38 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([211.166.10.233]) by mail.geekcn.org (mail.geekcn.org [211.166.10.233]) (amavisd-new, port 10024) with LMTP id Q6H155hFCKpI; Fri, 7 May 2010 01:10:31 +0800 (CST) Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id DDA9DA69502; Fri, 7 May 2010 01:10:28 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=TqjoP4xBx7XONek7nGSl4ETTyNk1YCdYbm9dbrMi3f4mDXruS6ZT0eFdQhjLd4MMF a889VpgtunpcfMQgFvtnQ== Message-ID: <4BE2F7FF.9070902@delphij.net> Date: Thu, 06 May 2010 10:10:23 -0700 From: Xin LI Organization: The Geek China Organization User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.1.9) Gecko/20100408 Thunderbird/3.0.4 ThunderBrowse/3.2.8.1 MIME-Version: 1.0 To: Bruce Evans References: <201005052124.o45LOJES067973@svn.freebsd.org> <20100506105825.B18998@delplex.bde.org> In-Reply-To: <20100506105825.B18998@delplex.bde.org> X-Enigmail-Version: 1.0.1 OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG, Xin LI Subject: Re: svn commit: r207677 - head/usr.bin/find X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2010 17:26:55 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2010/05/05 18:00, Bruce Evans wrote: > On Wed, 5 May 2010, Xin LI wrote: > >> Log: >> Move SCCS tags to comments as they were already #if 0'ed. > > This is explicitly disrecommended in style(9): > > All VCS (version control system) revision identification in files > obtained from elsewhere should be maintained, including, where > applica- > ble, multiple IDs showing a file's history. In general, do not > edit for- > eign IDs or their infrastructure. Unless otherwise wrapped (such as > ``#if defined(LIBC_SCCS)''), enclose both in ``#if 0 ... #endif'' > to hide > any uncompilable bits and to keep the IDs out of object files. > Only add > ``From: '' in front of foreign VCS IDs if the file is renamed. Sorry for that. I thought that the style(9) approach actually creates more diffs but I'll obey these rule. Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iQEcBAEBAgAGBQJL4vf/AAoJEATO+BI/yjfB8UQH/1RFuhSbshX6f7096nhQPsEv poHVmmYvEivhaE25PZkSSyBTVws4arN1IuBGerS2OKqBn+E3L09dHiSOxFG0qiTN wnNcfXZo/OuniSZIhcvBhkO0EgXsAhNacPDxrx+WjjQthnQPoM4bprVgfk6mHd+/ x8BXxxLwtbMawwf/QlA97/h2TpMab/Hmx4J3pV7dBLjDVzEmnPPiD0mMaqnffAW7 Z3nRNhydea014fUMUDr/wpIx0XOFJsIIHrPwWK5odQ1TUGxLqly4mBCwy//ydVLK bdUVnmU26j50zC6dQSvsO/tQEd4Katw/ITat2vLn5cA9i2KnWP4HMEGulGyW9JI= =19LB -----END PGP SIGNATURE-----