From owner-freebsd-stable@FreeBSD.ORG  Tue Apr 25 16:05:28 2006
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
X-Original-To: stable@freebsd.org
Delivered-To: freebsd-stable@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C754A16A400
	for <stable@freebsd.org>; Tue, 25 Apr 2006 16:05:28 +0000 (UTC)
	(envelope-from marck@rinet.ru)
Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 82B8C43D67
	for <stable@freebsd.org>; Tue, 25 Apr 2006 16:05:27 +0000 (GMT)
	(envelope-from marck@rinet.ru)
Received: from localhost (localhost [127.0.0.1])
	by woozle.rinet.ru (8.13.6/8.13.4) with ESMTP id k3PG5PUi075955;
	Tue, 25 Apr 2006 20:05:26 +0400 (MSD) (envelope-from marck@rinet.ru)
Date: Tue, 25 Apr 2006 20:05:25 +0400 (MSD)
From: Dmitry Morozovsky <marck@rinet.ru>
To: Kostik Belousov <kostikbel@gmail.com>
In-Reply-To: <20060425153909.GE1446@deviant.kiev.zoral.com.ua>
Message-ID: <20060425200348.B71240@woozle.rinet.ru>
References: <20060424181531.GA13774@xor.obsecurity.org>
	<20060425001751.S44618@woozle.rinet.ru>
	<20060424202859.GA18457@xor.obsecurity.org>
	<20060425004405.G44618@woozle.rinet.ru>
	<20060424205026.GA18844@xor.obsecurity.org>
	<20060425134418.J57625@woozle.rinet.ru>
	<20060425080932.1rv9hq0rcws4wc84@www.wolves.k12.mo.us>
	<20060425133532.GD1446@deviant.kiev.zoral.com.ua>
	<20060425095610.ibv24kg1kw00s040@www.wolves.k12.mo.us>
	<20060425185741.C71240@woozle.rinet.ru>
	<20060425153909.GE1446@deviant.kiev.zoral.com.ua>
X-NCC-RegID: ru.rinet
X-OpenPGP-Key-ID: 6B691B03
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2
	(woozle.rinet.ru [0.0.0.0]); Tue, 25 Apr 2006 20:05:26 +0400 (MSD)
Cc: stable@freebsd.org, Kris Kennaway <kris@obsecurity.org>
Subject: Re: fsck_ufs locked in snaplk
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Apr 2006 16:05:28 -0000

On Tue, 25 Apr 2006, Kostik Belousov wrote:

KB> > I just made lab machine with serial console, compile minimal kernel with quotas 
KB> > and KDB+WITNESS, and immediately after ``quotacheck /var && quotaon /var'' got
KB> > 
KB> > kdb_backtrace(d663aba0,c051f402,c05f7da3,c05fe731,c32cb414) at 
KB> > kdb_backtrace+0x29
KB> > vfs_badlock(c05f7da3,c05fe731,c32cb414) at vfs_badlock+0x11
KB> > assert_vop_locked(c32cb414,c05fe731,c30ed400,c04eac2c,c05f6cf4) at 

KB> Obviously, revisions 1.78, 1.79 of the sys/ufs/ufs/ufs_quota.c
KB> shall be MFCed. Try this patch (note, I does not tested it):

Yup, at least immediate drop to debugger disappeared. I'll check now with our 
situation: quotas with at least one user over quota *and* makinfg snapshot on 
this filesystem.


Sincerely,
D.Marck                                     [DM5020, MCK-RIPE, DM3-RIPN]
------------------------------------------------------------------------
*** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru ***
------------------------------------------------------------------------