From owner-svn-src-all@freebsd.org Fri Nov 2 13:35:42 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67AFE10F712A for ; Fri, 2 Nov 2018 13:35:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it1-x12a.google.com (mail-it1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D6A516AC6E for ; Fri, 2 Nov 2018 13:35:41 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it1-x12a.google.com with SMTP id p64-v6so3210814itp.0 for ; Fri, 02 Nov 2018 06:35:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TH9JcfjSyk++ayNaRyp1mIk6oV2pu18EDAoHkvGjO4Q=; b=xjvEN/pk8lU551/CQ+2TeVfksGqpJxVBI7R8fv+Qgl5eacLW6HCcHj/IEv7L5O2UZW +chEMUVPt2TtdVkjNWrd1EJOKoJpJ+qjBbyA6eJlWuevDI6B8RRrw4G7gugBhVgEXb+w UMCYzuFruuPSJ5iqYnDvjT+OkozX4HY1Y4wwxtpJofUY8007F/ApuyRuf6+mZvk/gQNk s9ndZ0aqkyKSirQv9J+WLrQdMmi8PbEUZjkIVFr4RnqdB1S/dtMr+Fpn8oFUaHisIImR mPi/3nX0Mo+0A44pdlzbBUyv8dak1vd1WLfuqiN33XAHNANrz9lsQSXCkVPKJwVJrg1+ +axw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TH9JcfjSyk++ayNaRyp1mIk6oV2pu18EDAoHkvGjO4Q=; b=Z1zsp4KZCwuwMqOKHzDMkzWMTv4gzOXTYM6kcxkJPJo1fbxgSUKLWJ2qYTINvolKta kDWqVDxKJhhMelIe1mSpDdn4I8SkEmGTi8lTmB6p9JTUVsM7ZnIWjJzwzR5rabLiX18Y AMPzYQAAl3R18qHHgTLfLNW4PO5/p/ezR68ABerzSzOBW3rx6bDblq3XHwnrbSQLR5bL QNVaoa0wEmqJW2xf4k5QAd6eV0P9mvb3YsVviNhQQmli7p4JkdQGG3Wt6mzqGgwptV3m Ud18a0wDqZ00gcPF8rXxsR2rZMKFvD7sJDh+ap7QIOe1HvdlL0N1xCbuWWcTbBE5FpTo 3mYQ== X-Gm-Message-State: AGRZ1gKHKqob4T6CQ7vp+FnUQpCT7WaVPkkyZER2OAaW0jft4qXZjofh ILtc9RZwUo3jh7SYhc1Ucrhuem5Fqt+P2KAtRvDY4/tj X-Google-Smtp-Source: AJdET5c4unsQtyf2bMMxt4sku74jFuTLTgvQBa5m9vFO7U8cQwP33r1SGIzNpIgrJ7IjGuBBS5Soi6XifWIW9A01nuY= X-Received: by 2002:a02:2708:: with SMTP id g8-v6mr9876691jaa.93.1541165741168; Fri, 02 Nov 2018 06:35:41 -0700 (PDT) MIME-Version: 1.0 References: <201811012346.wA1NkNS5079845@repo.freebsd.org> <20181102004555.GJ5335@kib.kiev.ua> <20181102094617.7340e6f2@ernst.home> In-Reply-To: <20181102094617.7340e6f2@ernst.home> From: Warner Losh Date: Fri, 2 Nov 2018 07:35:29 -0600 Message-ID: Subject: Re: svn commit: r340038 - in head: lib/libc/sys sys/kern To: Gary Jennejohn Cc: "Conrad E. Meyer" , Konstantin Belousov , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 13:35:42 -0000 On Fri, Nov 2, 2018 at 2:46 AM Gary Jennejohn wrote: > On Thu, 1 Nov 2018 20:29:27 -0700 > Conrad Meyer wrote: > > > On Thu, Nov 1, 2018 at 5:46 PM Konstantin Belousov > wrote: > > > > > > On Thu, Nov 01, 2018 at 11:46:23PM +0000, Conrad Meyer wrote: > > > > ... > > > > @@ -232,7 +232,15 @@ points outside the process's allocated address > space. > > > > A signal was delivered before the time limit expired and > > > > before any of the selected events occurred. > > > > .It Bq Er EINVAL > > > > -The specified time limit is invalid. One of its components is > negative or too large. > > > > +The specified time limit is invalid. > > > > +One of its components is negative or too large. > > > > +.It Bq Er EINVAL > > > > +The number of pollfd structures specified by > > > > +.Fa nfds > > > > +exceeds the system tunable > > > > +.Va kern.maxfilesperproc > > > > +and > > > > +.Dv FD_SETSIZE . > > > > > > This is somewhat confusing. Looking only at the man page text, most > > > straight reading of it is that nfds cannot exceed min(maxfilesperproc, > > > FD_SETSIZE). But in fact nfds cannot exceed max of it, which is > > > significantly different, i.e. poll(2) does not suffer from the > (userspace) > > > FD_SETSIZE limitation of select(2). > > > > min(maxfilesperproc, FD_SETSIZE) would be written as "nfds exceeds ... > > maxfilesperproc OR FD_SETSIZE," rather than "and." I think the > > sentence is unambiguous. > > > > Based on Konstantin's comment I'd have to say that it is not > unambiguous. > > As a native English speaker I had to read it several times to > understand it. > > I think something like "exceeds both" might be clearer. > "The number of pollfd structures specified by nfds exceeds both the system tunable and FD_SETSIZE" Or even "nfds is larger than both the system tunable and FD_SETSIZE" since the 'The number of pollfd structures" is repetitive given one can go look up what it specifies. Warner