Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Feb 2019 09:48:42 +0000
From:      =?UTF-8?Q?Vin=C3=ADcius_Zavam?= <egypcio@freebsd.org>
To:        svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, egypcio@freebsd.org
Cc:        dg@syrec.org
Subject:   Re: svn commit: r493868 - head/devel/git-lfs
Message-ID:  <CA%2BKr6DPx_Dv7r-dndnfubbOg4AfcM=Ua0w8cbXzAgW3zti=CKw@mail.gmail.com>
In-Reply-To: <20190225183656.GA81588@xombo.localdomain>
References:  <201902251433.x1PEXu6V095341@repo.freebsd.org> <20190225183656.GA81588@xombo.localdomain>

next in thread | previous in thread | raw e-mail | index | archive | help
Am Mo., 25. Feb. 2019 um 18:37 Uhr schrieb Dmitri Goutnik <dg@syrec.org>:

> On 19-02-25 14:33:56, Vin=C3=ADcius Zavam wrote:
> > Author: egypcio
> > Date: Mon Feb 25 14:33:56 2019
> > New Revision: 493868
> > URL: https://svnweb.freebsd.org/changeset/ports/493868
> >
> > Log:
> >   devel/git-lfs: update 2.6.1 to 2.7.0
> >
> >   Reported by:        portscout
> >   Approved by:        rene (mentor)
> >   Differential Revision:      https://reviews.freebsd.org/D19320
> >
> > Modified:
> >   head/devel/git-lfs/Makefile
> >   head/devel/git-lfs/distinfo
> >
> > Modified: head/devel/git-lfs/Makefile
> >
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> > --- head/devel/git-lfs/Makefile       Mon Feb 25 14:32:37 2019
> (r493867)
> > +++ head/devel/git-lfs/Makefile       Mon Feb 25 14:33:56 2019
> (r493868)
> > @@ -2,7 +2,7 @@
> >
> >  PORTNAME=3D            git-lfs
> >  DISTVERSIONPREFIX=3D   v
> > -DISTVERSION=3D         2.6.1
> > +DISTVERSION=3D         2.7.0
> >  CATEGORIES=3D          devel
> >
> >  MAINTAINER=3D  egypcio@FreeBSD.org
> > @@ -16,8 +16,25 @@ RUN_DEPENDS=3D       git:devel/git
> >  USES=3D                go
> >  USE_GITHUB=3D  yes
> >
> > -GH_TUPLE=3D    davecgh:go-spew:d8f796a:davecgh_spew/vendor/
> github.com/davecgh/go-spew \
> > -             pmezard:go-difflib:792786c:pmezard_difflib/vendor/
> github.com/pmezard/go-difflib
> > +GH_TUPLE=3D    alexbrainman:sspi:4729b3d:abm_sspi/vendor/
> github.com/alexbrainman/sspi \
> > +     git-lfs:gitobj:v1.1.0:glfs_obj/vendor/github.com/git-lfs/gitobj \
> > +     git-lfs:go-netrc:e0e9ca4:glfs_netrc/vendor/
> github.com/git-lfs/go-netrc \
> > +     git-lfs:wildmatch:v1.0.2:glfs_wildm/vendor/
> github.com/git-lfs/wildmatch \
> > +     inconshreveable:mousetrap:v1.0.0:ir_mtrap/vendor/
> github.com/inconshreveable/mousetrap \
> > +     kr:pty:5cf931e:kr_pty/vendor/github.com/kr/pty \
> > +     mattn:go-isatty:v0.0.4:mattn_isatty/vendor/
> github.com/mattn/go-isatty \
> > +     olekukonko:ts:78ecb04:okk_ts/vendor/github.com/olekukonko/ts \
> > +     pkg:errors:c605e28:pkg_err/vendor/github.com/pkg/errors \
> > +     rubyist:tracerx:7879593:rubyist_tracerx/vendor/
> github.com/rubyist/tracerx \
> > +     spf13:cobra:v0.0.3:spf_cobra/vendor/github.com/spf13/cobra \
> > +     spf13:pflag:v1.0.3:spf_pflag/vendor/github.com/spf13/pflag \
> > +     stretchr:testify:v1.2.2:stretch_testify/vendor/
> github.com/stretchr/testify \
> > +     ThomsonReutersEikon:go-ntlm:b00ec39:tre_ntlm/vendor/
> github.com/ThomsonReutersEikon/go-ntlm \
> > +     xeipuuv:gojsonpointer:4e3ac27:xei_pointer/vendor/
> github.com/xeipuuv/gojsonpointer \
> > +     xeipuuv:gojsonreference:bd5ef7b:xei_ref/vendor/
> github.com/xeipuuv/gojsonreference \
> > +     xeipuuv:gojsonschema:6b67b3f:xei_schem/vendor/
> github.com/xeipuuv/gojsonschema \
> > +     golang:sync:37e7f08:golang_sync/vendor/golang.org/x/sync \
> > +     golang:sys:fa5fdf9:golang_sys/vendor/golang.org/x/sys
> >
>
> Hi Vin=C3=ADcius,
>
> Upstream has all dependencies vendored [1], why list them in GH_TUPLE?
>
> >  GO_PKGNAME=3D  github.com/${PORTNAME}/${PORTNAME}
> <http://github.com/$%7BPORTNAME%7D/$%7BPORTNAME%7D>;
> >
> > @@ -26,6 +43,9 @@ OPTIONS_DEFAULT=3D    MANPAGES
> >  OPTIONS_SUB=3D         yes
> >
> >  MANPAGES_BUILD_DEPENDS=3D      ronn:textproc/rubygem-ronn
> > +
> > +pre-build:
> > +     ${RM} ${GO_WRKSRC}/go.mod
>
> This is not needed because module support is off (unless explicitly
> activated)
> when building packages under $GOPATH.
>
> [1] https://github.com/git-lfs/git-lfs/tree/v2.7.0
>
> Regards,
> Dmitri
>

Hi Dmitri,
how are things?

thanks! appreciated your concern. patched, built and tested. all fine;
+ https://reviews.freebsd.org/D19363 :-)

KR,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BKr6DPx_Dv7r-dndnfubbOg4AfcM=Ua0w8cbXzAgW3zti=CKw>