From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Aug 1 21:30:25 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10A5C16A4CE for ; Sun, 1 Aug 2004 21:30:25 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF5A043D54 for ; Sun, 1 Aug 2004 21:30:24 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i71LUONK064469 for ; Sun, 1 Aug 2004 21:30:24 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i71LUOg1064459; Sun, 1 Aug 2004 21:30:24 GMT (envelope-from gnats) Resent-Date: Sun, 1 Aug 2004 21:30:24 GMT Resent-Message-Id: <200408012130.i71LUOg1064459@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alexander Marx Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2673616A4E3 for ; Sun, 1 Aug 2004 21:25:54 +0000 (GMT) Received: from cronos.madness.at (madness.at [213.153.61.104]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE9AB43D4C for ; Sun, 1 Aug 2004 21:25:53 +0000 (GMT) (envelope-from mad@madness.at) Received: from mad by cronos.madness.at with local (Exim 4.33) id 1BrNq4-000ACs-QS for FreeBSD-gnats-submit@freebsd.org; Sun, 01 Aug 2004 23:25:52 +0200 Message-Id: Date: Sun, 01 Aug 2004 23:25:52 +0200 From: Alexander Marx To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/69885: [patch] unbreak xmbmon for gcc 3.4.2 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Alexander Marx List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Aug 2004 21:30:25 -0000 >Number: 69885 >Category: ports >Synopsis: [patch] unbreak xmbmon for gcc 3.4.2 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Aug 01 21:30:24 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Alexander Marx >Release: FreeBSD 5.2-CURRENT i386 >Organization: >Environment: System: FreeBSD cube.madness.at 5.2-CURRENT FreeBSD 5.2-CURRENT #0: Sat Jul 31 01:35:04 CEST 2004 root@cube.madness.at:/usr/src/sys/i386/compile/CUBE1 i386 >Description: xmbmon port fails to compile on -current with gcc 3.4.2 >How-To-Repeat: on a system with gcc 3.4.2 cd /usr/ports/sysutils/xmbmon make the compile then stops with cc -O -pipe -I. -DHAVE_CONFIG_H -Wall -s -o testsmb testsmb.c pci_pm.o smbuses.o smbus_piix4.o smbus_amd.o smbus_ali.o smbus_amd8.o testsmb.c: In function `main': testsmb.c:146: error: label at end of compound statement *** Error code 1 Stop in /usr/ports/sysutils/xmbmon/work/xmbmon204. *** Error code 1 Stop in /usr/ports/sysutils/xmbmon. >Fix: the following small patch seems to fix this; verified to build/run on 5.2-CURRENT (as of Jul 31) and 4.10-STABLE (from Jul 17). --- testsmb.c.orig Sun Aug 1 22:51:49 2004 +++ testsmb.c Sun Aug 1 22:55:12 2004 @@ -126,7 +126,7 @@ break; default: fprintf(stderr, "No known SMBus(I2C) chip found.\n"); - goto exit; + continue; } if(OpenIO() == -1) return -1; @@ -141,7 +141,6 @@ } CloseIO(); -exit: } /* endo of Big roop for smb_base candidates */ exit (0); >Release-Note: >Audit-Trail: >Unformatted: