From owner-cvs-all@FreeBSD.ORG Thu Mar 27 14:43:57 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 33F2537B404; Thu, 27 Mar 2003 14:43:57 -0800 (PST) Received: from angelica.unixdaemons.com (angelica.unixdaemons.com [209.148.64.135]) by mx1.FreeBSD.org (Postfix) with ESMTP id 201F444047; Thu, 27 Mar 2003 14:43:53 -0800 (PST) (envelope-from bmilekic@unixdaemons.com) Received: from angelica.unixdaemons.com (localhost.unixdaemons.com [127.0.0.1])h2RMhjV5066253; Thu, 27 Mar 2003 17:43:45 -0500 (EST) Received: (from bmilekic@localhost) by angelica.unixdaemons.com (8.12.8/8.12.1/Submit) id h2RMhjGP066252; Thu, 27 Mar 2003 17:43:45 -0500 (EST) (envelope-from bmilekic@unixdaemons.com) X-Authentication-Warning: angelica.unixdaemons.com: bmilekic set sender to bmilekic@unixdaemons.com using -f Date: Thu, 27 Mar 2003 17:43:45 -0500 From: Bosko Milekic To: Mike Silbersack Message-ID: <20030327224345.GA66106@unixdaemons.com> References: <200303260452.h2Q4quap015364@www.ambrisko.com> <20030326114030.U2075@odysseus.silby.com> <20030326183351.GJ57674@elvis.mu.org> <20030326130903.G2075@odysseus.silby.com> <20030327013224.P7674@odysseus.silby.com> <20030327164402.GA15454@unixdaemons.com> <20030327165800.GK57674@elvis.mu.org> <20030327171501.GA18549@unixdaemons.com> <20030327163012.F748@odysseus.silby.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030327163012.F748@odysseus.silby.com> User-Agent: Mutt/1.4.1i X-Spam-Status: No, hits=-35.2 required=5.0 tests=AWL,EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT, REFERENCES,REPLY_WITH_QUOTES,USER_AGENT_MUTT,X_AUTH_WARNING version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf options src/sys/netinet ip_output.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2003 22:43:59 -0000 On Thu, Mar 27, 2003 at 04:31:02PM -0600, Mike Silbersack wrote: > > I'll give this a shot when I get time to work on the patch next. If a > similar change to m_dup_pkthdr works fine, do you want me to go ahead and > commit it? Yes. Just make sure to test and let me know if/when you do, because I have some other improvements which rely on this change in my tree. > Thanks, > > Mike "Silby" Silbersack > > On Thu, 27 Mar 2003, Bosko Milekic wrote: > > > > > See attached. Similar logic may be applied to m_dup_pkthdr(). > > > > On Thu, Mar 27, 2003 at 05:58:00PM +0100, Maxime Henrion wrote: > > > Bosko Milekic wrote: > > > > > > > > Can you please still use m_gethdr() or m_getcl() to do the allocations > > > > in the defragment function? Similarly, for > MCLBYTES, use m_getm(). > > > > Don't roll your own. > > > > > > Please see my reply to Mike for the first version of his patch. He > > > couldn't do this because m_dup_pkthdr() has a KASSERT() that makes it > > > panic if we have a cluster attached to the mbuf. > > > > > > Cheers, > > > Maxime > > > > > > > -- > > Bosko Milekic > > bmilekic@unixdaemons.com > > bmilekic@FreeBSD.org > > > > > -- Bosko Milekic bmilekic@unixdaemons.com bmilekic@FreeBSD.org