From owner-freebsd-current@FreeBSD.ORG Tue Apr 28 17:32:38 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D5EFF1065674; Tue, 28 Apr 2009 17:32:38 +0000 (UTC) (envelope-from gelraen.ua@gmail.com) Received: from mail-qy0-f105.google.com (mail-qy0-f105.google.com [209.85.221.105]) by mx1.freebsd.org (Postfix) with ESMTP id 6F4468FC18; Tue, 28 Apr 2009 17:32:38 +0000 (UTC) (envelope-from gelraen.ua@gmail.com) Received: by qyk3 with SMTP id 3so1424057qyk.3 for ; Tue, 28 Apr 2009 10:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=QQhLIB+xi/yakIIvY4c7lFkYxun8Bw9W3jDafFJ5tOo=; b=ink+O0Zt5pe8l8GFt+A9vU9Yb9XKRLgmWl9DRc/q8f2/oX21plycv1jiUIgByv32Hb eYsu1SfJcnI5Dc9hdFzjuClAzkFnyPIuGeqhKFJpAltCaAFuxYWmrrQ+QFiNTbV4R3eX iZEcMmhWyO6QDU+l5ZFMXGLf6EV5ae05wzlU4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=cDGdq1BKoL9zSX2e2byOPs7cJLW0NeqXfKikIvw9mxvn4+Y/iIU5PxbqPhtFjFA9ak YvmdLP9K5pG7ERHoisnfDoqUi/A160/2v4gseQodu/Yhk1U5eBBGURgOKrbYlvj1gH8N gTzNaQ/PVPyLIrBNw1ry0gaPxviDMjS3B58FU= MIME-Version: 1.0 Received: by 10.220.46.147 with SMTP id j19mr13493314vcf.75.1240939957281; Tue, 28 Apr 2009 10:32:37 -0700 (PDT) In-Reply-To: References: Date: Tue, 28 Apr 2009 20:32:37 +0300 Message-ID: From: Maxim Ignatenko To: bug-followup@freebsd.org, gdef@wp.pl Content-Type: multipart/mixed; boundary=0016363b88a65766ad0468a0d95b Cc: freebsd-current@freebsd.org Subject: Re: kern/132715: [lagg] [panic] Panic when creating vlan's on lagg interface X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Apr 2009 17:32:39 -0000 --0016363b88a65766ad0468a0d95b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit em(4), igb(4) and ixgbe(4) registers EVENTHANDLER vlan_config, but don't do any checks that this event generated by adding vlan on top of their devices. I'm don't completely sure what the right way to fix this issue, but attached patch works for me. --0016363b88a65766ad0468a0d95b Content-Type: text/plain; charset=US-ASCII; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fu2vk99w0 SW5kZXg6IGUxMDAwL2lmX2lnYi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGUxMDAwL2lmX2lnYi5jCShyZXZp c2lvbiAxOTEyMDEpCisrKyBlMTAwMC9pZl9pZ2IuYwkod29ya2luZyBjb3B5KQpAQCAtNDI3NCw2 ICs0Mjc0LDggQEAKIAlzdHJ1Y3QgYWRhcHRlcgkqYWRhcHRlciA9IGlmcC0+aWZfc29mdGM7CiAJ dTMyCQljdHJsLCByY3RsLCBpbmRleCwgdmZ0YTsKIAorCWlmIChzdHJjbXAoImlnYiIsaWZwLT5p Zl9kbmFtZSkpIHJldHVybjsKKwogCWN0cmwgPSBFMTAwMF9SRUFEX1JFRygmYWRhcHRlci0+aHcs IEUxMDAwX0NUUkwpOwogCWN0cmwgfD0gRTEwMDBfQ1RSTF9WTUU7CiAJRTEwMDBfV1JJVEVfUkVH KCZhZGFwdGVyLT5odywgRTEwMDBfQ1RSTCwgY3RybCk7CkBAIC00MzA2LDYgKzQzMDgsOCBAQAog CXN0cnVjdCBhZGFwdGVyCSphZGFwdGVyID0gaWZwLT5pZl9zb2Z0YzsKIAl1MzIJCWluZGV4LCB2 ZnRhOwogCisJaWYgKHN0cmNtcCgiaWdiIixpZnAtPmlmX2RuYW1lKSkgcmV0dXJuOworCiAJLyog UmVtb3ZlIGVudHJ5IGluIHRoZSBoYXJkd2FyZSBmaWx0ZXIgdGFibGUgKi8KIAlpbmRleCA9ICgo dnRhZyA+PiA1KSAmIDB4N0YpOwogCXZmdGEgPSBFMTAwMF9SRUFEX1JFR19BUlJBWSgmYWRhcHRl ci0+aHcsIEUxMDAwX1ZGVEEsIGluZGV4KTsKSW5kZXg6IGUxMDAwL2lmX2VtLmMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gZTEwMDAvaWZfZW0uYwkocmV2aXNpb24gMTkxMjAxKQorKysgZTEwMDAvaWZfZW0uYwko d29ya2luZyBjb3B5KQpAQCAtNDc3MSw2ICs0NzcxLDggQEAKIAlzdHJ1Y3QgYWRhcHRlcgkqYWRh cHRlciA9IGlmcC0+aWZfc29mdGM7CiAJdTMyCQljdHJsLCByY3RsLCBpbmRleCwgdmZ0YTsKIAor CWlmIChzdHJjbXAoImVtIixpZnAtPmlmX2RuYW1lKSkgcmV0dXJuOworCiAJY3RybCA9IEUxMDAw X1JFQURfUkVHKCZhZGFwdGVyLT5odywgRTEwMDBfQ1RSTCk7CiAJY3RybCB8PSBFMTAwMF9DVFJM X1ZNRTsKIAlFMTAwMF9XUklURV9SRUcoJmFkYXB0ZXItPmh3LCBFMTAwMF9DVFJMLCBjdHJsKTsK QEAgLTQ4MDMsNiArNDgwNSw4IEBACiAJc3RydWN0IGFkYXB0ZXIJKmFkYXB0ZXIgPSBpZnAtPmlm X3NvZnRjOwogCXUzMgkJaW5kZXgsIHZmdGE7CiAKKwlpZiAoc3RyY21wKCJlbSIsaWZwLT5pZl9k bmFtZSkpIHJldHVybjsKKwogCS8qIFJlbW92ZSBlbnRyeSBpbiB0aGUgaGFyZHdhcmUgZmlsdGVy IHRhYmxlICovCiAJaW5kZXggPSAoKHZ0YWcgPj4gNSkgJiAweDdGKTsKIAl2ZnRhID0gRTEwMDBf UkVBRF9SRUdfQVJSQVkoJmFkYXB0ZXItPmh3LCBFMTAwMF9WRlRBLCBpbmRleCk7CkluZGV4OiBp eGdiZS9peGdiZS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGl4Z2JlL2l4Z2JlLmMJKHJldmlzaW9uIDE5MTIw MSkKKysrIGl4Z2JlL2l4Z2JlLmMJKHdvcmtpbmcgY29weSkKQEAgLTQwMzEsNiArNDAzMSw4IEBA CiAJc3RydWN0IGFkYXB0ZXIJKmFkYXB0ZXIgPSBpZnAtPmlmX3NvZnRjOwogCXUzMgkJY3RybCwg cmN0bCwgaW5kZXgsIHZmdGE7CiAKKwlpZiAoc3RyY21wKCJpeGdiZSIsaWZwLT5pZl9kbmFtZSkp IHJldHVybjsKKwogCWN0cmwgPSBJWEdCRV9SRUFEX1JFRygmYWRhcHRlci0+aHcsIElYR0JFX1ZM TkNUUkwpOwogCWN0cmwgfD0gSVhHQkVfVkxOQ1RSTF9WTUUgfCBJWEdCRV9WTE5DVFJMX1ZGRTsK IAljdHJsICY9IH5JWEdCRV9WTE5DVFJMX0NGSUVOOwpAQCAtNDA1MCw2ICs0MDUyLDggQEAKIAlz dHJ1Y3QgYWRhcHRlcgkqYWRhcHRlciA9IGlmcC0+aWZfc29mdGM7CiAJdTMyCQlpbmRleCwgdmZ0 YTsKIAorCWlmIChzdHJjbXAoIml4Z2JlIixpZnAtPmlmX2RuYW1lKSkgcmV0dXJuOworCiAJLyog UmVtb3ZlIGVudHJ5IGluIHRoZSBoYXJkd2FyZSBmaWx0ZXIgdGFibGUgKi8KIAlpeGdiZV9zZXRf dmZ0YSgmYWRhcHRlci0+aHcsIHZ0YWcsIDAsIEZBTFNFKTsKIAo= --0016363b88a65766ad0468a0d95b--