From owner-svn-ports-head@FreeBSD.ORG Fri Nov 9 17:19:50 2012 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2AD0E121 for ; Fri, 9 Nov 2012 17:19:50 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 8A38C8FC17 for ; Fri, 9 Nov 2012 17:19:49 +0000 (UTC) Received: by mail-la0-f54.google.com with SMTP id e12so3985518lag.13 for ; Fri, 09 Nov 2012 09:19:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=VyO0RpvCuxesM/ivvXhRF5GH+qn9frJXgSYt69laVbA=; b=KnXPSbySamVrn+1y+JziZAb0B9O+5c6ZhlKRa86pX/gA3ww28pPhdKlSDhsNaaW2Uv qJQ27THGYiKFC/hD+1bpIfv+jlUU8vfmL+lRGxldHzFC+FiRHpcjlkWEqmjGtjjO3+c5 lEIQayI6jMjcKaq9GPz9kCHlrHaclp0WjNWUU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=VyO0RpvCuxesM/ivvXhRF5GH+qn9frJXgSYt69laVbA=; b=My1d/ErwT2LFlssOE6zeUyGcucmlAL5XmdKbazo45vbd+ZRl3em4LfIrH4FpKFP7AF NtZhckVXTucsUTu+1yZLSLp7UsktEUCR4hy1ZF0Oge+5QtkUeVSLZyE7AbO/rmlFLJ6D JgjbAL5Fv7pf7var4dS06UVV7vgr5hI6W04e6PXJI4vFAE3YMxGmaG32p7/sYcCsVj9t sleyqNsIPqYTilBKbWsCJGebFeeGvUdC6gHl3AHfNL7xHpt3lMiBWSEbGJHFQDIYD3F+ ciHRnGxqFLnw38QkVUGTWOMMReqACr4fWfEhJO7mVT2FXY/jpADKIRgGcJcgn1RDUWfO A0RA== Received: by 10.112.13.140 with SMTP id h12mr4942523lbc.12.1352481588143; Fri, 09 Nov 2012 09:19:48 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.25.166 with HTTP; Fri, 9 Nov 2012 09:19:17 -0800 (PST) In-Reply-To: <509D3945.3070101@FreeBSD.org> References: <201210201559.q9KFx4mA060483@svn.freebsd.org> <509D216D.4020809@FreeBSD.org> <509D3945.3070101@FreeBSD.org> From: Eitan Adler Date: Fri, 9 Nov 2012 12:19:17 -0500 X-Google-Sender-Auth: p7GuEbs0ydaYxp1hiE5xhnPeUME Message-ID: Subject: Re: svn commit: r306199 - in head/devel/readline: . files To: Bryan Drewery Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQleAzH5r1bcHb6XD+HrvCkAUuBdRWG4IIkjVbNiZYPwUuWybZlCdp0L0skY2yigo69bT+Qe Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2012 17:19:50 -0000 On 9 November 2012 12:11, Bryan Drewery wrote: > On 11/9/2012 9:29 AM, Bryan Drewery wrote: >> On 10/20/2012 10:59 AM, Eitan Adler wrote: >>> Author: eadler >>> Date: Sat Oct 20 15:59:04 2012 >>> New Revision: 306199 >>> URL: http://svn.freebsd.org/changeset/ports/306199 >>> >>> Log: >>> Convert to OptionsNG >>> Remove stale patch (seems to not matter anymore with recent gcc versions) >>> >>> Feature safe: yes >>> >>> Deleted: >>> head/devel/readline/files/support_shobj-conf.diff >>> Modified: >>> head/devel/readline/Makefile >>> >>> Modified: head/devel/readline/Makefile >>> ============================================================================== >>> --- head/devel/readline/Makefile Sat Oct 20 15:55:45 2012 (r306198) >>> +++ head/devel/readline/Makefile Sat Oct 20 15:59:04 2012 (r306199) >>> @@ -20,12 +20,8 @@ MAN3= readline.3 history.3 >>> >>> .include >>> >>> -.if ${ARCH} == "sparc64" >>> -EXTRA_PATCHES+= ${FILESDIR}/support_shobj-conf.diff >>> -.endif >>> - >>> pre-configure: >>> -.if !defined(WITHOUT_TERMCAP) >>> +.if ${PORT_OPTIONS:MNLS} >>> ${REINPLACE_CMD} "s/SHOBJ_LDFLAGS =/SHOBJ_LDFLAGS = -ltermcap/" ${WRKSRC}/shlib/Makefile.in >>> .endif >>> >> >> This effectively changes TERMCAP from being default to now not-default. This should have been fixed in r306201. If I missed something please fix it w/ my approval. I won't have time to look into this for some time. FWIW, I've also received one report that this revision broke readline on i386, but I can't reproduce on my VM, and I've asked others to reproduce, and they can not. If anyone else is having trouble with readline please let me know. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams