From owner-svn-src-all@freebsd.org Wed May 23 13:35:08 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59EF8EFDE1E for ; Wed, 23 May 2018 13:35:08 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22d.google.com (mail-it0-x22d.google.com [IPv6:2607:f8b0:4001:c0b::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CD7246AF64 for ; Wed, 23 May 2018 13:35:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22d.google.com with SMTP id p3-v6so4435871itc.0 for ; Wed, 23 May 2018 06:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=1BM6Io1QDQt03OIMkfoRdl8M2O6eM656/FIeNYT0I6g=; b=fpu5mdh9LrPBG+xYAHjZixBsjimJCdiBx/SDXPSrWrgP4wDktmMxieuuPvBVt4t2MT lSiyUfyBG3LvEY9ZtRt1X5KFG1AmQz+7Pf1jqmoqLX+hDyXWe8YbSwJiumaKlgX5esFz 6I1u2d9ReTARdUpWsZOCSpFI96V96ufpPt9J6uszIt/3mujyY/7caW6xm9ipypRWdcA0 VhQTuLVbfMhd8RGShpc9f+6CxnNCNwg1BrF4ZSQaR+H5FLmRPtUYEWhYo53OhIjA/Rmh 9nli9gxgaw3PxWffevwYoBsrPkxIKL49iZBD4Fsak2kUf0RxCrAqGEenuEkoNlHpU3VZ 5dkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=1BM6Io1QDQt03OIMkfoRdl8M2O6eM656/FIeNYT0I6g=; b=R5k7q+BEjJA45HSWZRNz69tS6LSYqdyzpAUme4VePl5AzjL0dxSf9ll+Vot6BdL7Df bukscVklvFugcqGOw1fAqSiX1A3d71OozU/7Xwes4JzRVTyC4uHypC9Mduupw60dPiBC N8byTmPReMMtN8bByJZu3Y5W7121+5be/7Z9JoK8he0p45iFJroYQyrB8DmgJODpaFPF 8suURRt6oSssfbsm59fw6Aj5wcUG5lSkkSlV7JxsSvZjzgdSV55vKivjoFb4QMNNCJxT wzwNrfWcKjmCxt18A/5bvjSpK6x3QYxsz0YS2n6BXtKbsKLRaqGe12PbaVjxYmjma8Sw vK0w== X-Gm-Message-State: ALKqPwdNjMlN9wBo0ZBglEQs38refkL4VjODSg9vQ9olvYNRKB7Ca7/i vu1IerDjO7+1/NTMnNRCjh48LnfQyjGQJ7eeetwlFw== X-Google-Smtp-Source: ADUXVKKX4RsWi6Km+FsQDfwIImc8xjOoV7k6++ECBmJjxLuVO8L+rRBNFDxFnIBkYbF6A/43JMytQVGpq1TvSIKEQCA= X-Received: by 2002:a24:42c6:: with SMTP id i189-v6mr5076779itb.73.1527082506772; Wed, 23 May 2018 06:35:06 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:d028:0:0:0:0:0 with HTTP; Wed, 23 May 2018 06:35:06 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <201805230739.w4N7d5Z1062496@repo.freebsd.org> References: <201805230739.w4N7d5Z1062496@repo.freebsd.org> From: Warner Losh Date: Wed, 23 May 2018 07:35:06 -0600 X-Google-Sender-Auth: dwtXbCFmOyWuHr7sbkt4Ym-fw4Q Message-ID: Subject: Re: svn commit: r334078 - head/sbin/devd To: Eitan Adler Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 13:35:08 -0000 On Wed, May 23, 2018 at 1:39 AM, Eitan Adler wrote: > Author: eadler > Date: Wed May 23 07:39:05 2018 > New Revision: 334078 > URL: https://svnweb.freebsd.org/changeset/base/334078 > > Log: > devd: compile at WARNS=6 > > Verified with "make universe TARGETS='amd64 arm arm64 i386 sparc64'" > > Modified: > head/sbin/devd/Makefile > head/sbin/devd/devd.cc > head/sbin/devd/token.l > > ... > Modified: head/sbin/devd/token.l > ============================================================ > ================== > --- head/sbin/devd/token.l Wed May 23 07:39:02 2018 (r334077) > +++ head/sbin/devd/token.l Wed May 23 07:39:05 2018 (r334078) > @@ -38,6 +38,7 @@ > #include "devd.h" > #include "y.tab.h" > > +extern int lineno; > int lineno = 1; > > static void This is completely bogus. Never ever ever just put extern in the line before to avoid the warning. That's wrong 100% of the time. Fix it right by putting this in devd.h. Warner