From owner-freebsd-fs@FreeBSD.ORG Fri Apr 2 13:15:58 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 785D5106564A for ; Fri, 2 Apr 2010 13:15:58 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-bw0-f228.google.com (mail-bw0-f228.google.com [209.85.218.228]) by mx1.freebsd.org (Postfix) with ESMTP id 0068D8FC0C for ; Fri, 2 Apr 2010 13:15:57 +0000 (UTC) Received: by bwz28 with SMTP id 28so1544361bwz.14 for ; Fri, 02 Apr 2010 06:15:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject :organization:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=yxRYcJDBuoTSUHHv8QSR/c5adRVi1MMSvH6tNjej55Y=; b=MpLHc1JdRLiCSQnWK/5Hkb1aiA4sncIW3nZN3r54w/Jg6M9km0Ne11REzcthNIaVZw /zSQz19jSZEOgm3Sah8bqGG7HwubYHfkn7QWM1KX/2OgXS947gjf5ZRFNqGXgFBRnshQ Ywr17ZUskJpvexmuz8RsIFNNn8Qi9EY+Rfo7Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=MIJAup3Eb2Q2JINk3iF5CU+ZF/U2GMnJpTboLuMLtnKNZsxrj7e5pucB9LesD7gfji tDksPM0G0wZ1turrxO8Uw3FePE7JYBTCf/m2Ok+uD+JrdgY3wfw0kpWR6C1x8kFpTKqW a4ERPrHhhnfIGNyYUD62hqeLQfpbcP0J+5aZc= Received: by 10.204.8.205 with SMTP id i13mr3087984bki.109.1270214156842; Fri, 02 Apr 2010 06:15:56 -0700 (PDT) Received: from localhost (ua1.etadirect.net [91.198.140.16]) by mx.google.com with ESMTPS id 16sm4518934bwz.1.2010.04.02.06.15.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 02 Apr 2010 06:15:56 -0700 (PDT) From: Mikolaj Golub To: Kostik Belousov Organization: TOA Ukraine References: <86sk7e1gad.fsf@zhuzha.ua1> <20100402090401.GG2415@deviant.kiev.zoral.com.ua> <86wrwqnlgp.fsf@zhuzha.ua1> <20100402121459.GH2415@deviant.kiev.zoral.com.ua> Date: Fri, 02 Apr 2010 16:15:54 +0300 In-Reply-To: <20100402121459.GH2415@deviant.kiev.zoral.com.ua> (Kostik Belousov's message of "Fri, 2 Apr 2010 15:14:59 +0300") Message-ID: <86r5myq9kl.fsf@zhuzha.ua1> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: freebsd-fs@freebsd.org, Eugene Grosbein Subject: Re: Lock leakage on rename if vop->vop_rename is NULL (kern/107439) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2010 13:15:58 -0000 On Fri, 2 Apr 2010 15:14:59 +0300 Kostik Belousov wrote: KB> On Fri, Apr 02, 2010 at 02:27:18PM +0300, Mikolaj Golub wrote: >> >> On Fri, 2 Apr 2010 12:04:01 +0300 Kostik Belousov wrote: >> >> KB> Please test the patch below. If it works for you, I will combine >> KB> deadfs_rename() and vop_norename(). >> >> Tested on today's 8.0-STABLE i386. Trying to move from/to/inside ntfs: no >> locking issues or problems with unmounting fs (and any other strange things) >> have been detected. KB> Great, thank you. KB> Below is the patch I intent to commit. Will be grateful if you sanity-check KB> it too. Tested. It works for me. -- Mikolaj Golub