From owner-cvs-all@FreeBSD.ORG Sat Jan 26 17:13:37 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4812616A418 for ; Sat, 26 Jan 2008 17:13:37 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with SMTP id E750213C447 for ; Sat, 26 Jan 2008 17:13:36 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 21791 invoked by uid 399); 26 Jan 2008 17:13:36 -0000 Received: from localhost (HELO ?192.168.0.4?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 26 Jan 2008 17:13:36 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <479B6A3D.10108@FreeBSD.org> Date: Sat, 26 Jan 2008 09:13:33 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Joe Marcus Clarke References: <200801201628.m0KGSlq6037319@repoman.freebsd.org> <200801212057.33990@aldan> <20080122022122.GA37321@k7.mavetju> <200801220929.29201.mi+mill@aldan.algebra.com> <1201027632.54891.6.camel@shumai.marcuscom.com> In-Reply-To: <1201027632.54891.6.camel@shumai.marcuscom.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: Mikhail Teterin , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, Edwin Groothuis , Mikhail Teterin , cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/net/ekiga pkg-plist X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jan 2008 17:13:37 -0000 Joe Marcus Clarke wrote: > On Tue, 2008-01-22 at 09:29 -0500, Mikhail Teterin wrote: >> ????????? 21 ?????? 2008 09:21 ??, Edwin Groothuis ?? ????????: >>>> The new package NEVER built because of the problem, that was just fixed. >>> It's more to differentiate between working and non-working versions. >> They are both working versions. If you need to make a distinction, you can >> look at the $FreeBSD$-string. >> >> Bumping up the PORTREVISION would trigger an utterly useless rebuild on >> thousands (millions?) of end-user computers and should not be performed >> lightly. While I agree with that in principle, I'm confused by your earlier statement. Were users able to compile and install this new version of the port previously, and only the package building was broken? > It would trigger a rebuild which would provide a correct pkg-plist. For > this reason alone, policy mandates any plist change requires a > PORTREVISION bump. Applying that policy without careful thought means that you're putting the needs of the system ahead of what is best for our users. Stepping away from this particular port for a second, if you have a port that never compiled, installed, or packaged; then you fix it, bumping PORTREVISION is meaningless either way. It doesn't affect the users or the (non-existent) package. If only packaging is broken, bumping PORTREVISION is not just pointless, it's actually harmful to users since they have to rebuild something that won't actually change, and they can just as easily pick up the plist fix on the next legitimate update. (There is an edge case here where what is fixed in this plist update won't be present in the next version, which would obviously require a bump.) It's way too easy to say, "oh, this knob is shiny, let's turn it!" without thinking of where the benefits lie for the users. I personally like the way someone else stated the principle, "If a change affects the package, PORTREVISION should be bumped." That makes sense, and balances the needs of the system and the needs of the user. Doug -- This .signature sanitized for your protection