From owner-svn-src-head@freebsd.org  Wed Nov 29 10:06:04 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2F924DFF19B;
 Wed, 29 Nov 2017 10:06:04 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 0FBDD6DCFC;
 Wed, 29 Nov 2017 10:06:04 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 4E217EF02; Wed, 29 Nov 2017 10:06:03 +0000 (UTC)
Date: Wed, 29 Nov 2017 10:06:03 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Bruce Evans <brde@optusnet.com.au>
Cc: Edward Tomasz Napierala <trasz@freebsd.org>, svn-src-head@freebsd.org,
 svn-src-all@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r326314 - in head/sys: ddb kern sys
Message-ID: <20171129100603.GA30636@FreeBSD.org>
References: <201711281253.vASCrtlB071488@repo.freebsd.org>
 <20171129030035.W2283@besplex.bde.org>
 <20171129065701.GB71839@FreeBSD.org>
 <20171129200224.A930@besplex.bde.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171129200224.A930@besplex.bde.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Nov 2017 10:06:04 -0000

On Wed, Nov 29, 2017 at 08:52:04PM +1100, Bruce Evans wrote:
> On Wed, 29 Nov 2017, Alexey Dokuchaev wrote:
> ...
> X Index: kern/subr_kdb.c
> X ===================================================================
> X --- kern/subr_kdb.c	(revision 326310)
> X +++ kern/subr_kdb.c	(working copy)
> X @@ -224,7 +224,7 @@
> X  	return (0);
> X  }
> X 
> X -void
> X +static void
> X  kdb_panic(const char *msg)
> X  {
> X 
> X @@ -232,7 +232,7 @@
> X  	panic("%s", msg);
> X  }
> X 
> X -void
> X +static void
> X  kdb_reboot(void)
> X  {
> 
> These changes are problematic.  They don't compile, since the functions
> are still declared as implicit-extern in <sys/kdb.h>.  More seriously,
> if these functions can be static because they are only called from
> kdb_alternate_break_internal(), then all calls to them are broken since
> "alternate" "break"s are broken (more broken than their name).  They
> are done from interrupt handlers where it is invalid to call almost any
> function for the "fast" interrupt handler case (serial console drivers)
> and invalid to call most functions in the normal interrupt handler case
> (syscons and vt). [...]

Yes, I was already told that they are part of public KPI and thus cannot
be easily removed.  This issue is to be discussed separately.

> The style fixes are correct.

Thanks; I've already got approval from bapt@ for those and intend to
commit them shortly.

./danfe