From owner-svn-src-head@freebsd.org Thu Jan 14 21:46:15 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 57806A83427 for ; Thu, 14 Jan 2016 21:46:15 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm2-vm1.bullet.mail.bf1.yahoo.com (nm2-vm1.bullet.mail.bf1.yahoo.com [98.139.213.158]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0FD3E134A for ; Thu, 14 Jan 2016 21:46:14 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1452807972; bh=g3gH2I0MKjWw5nlSbPy6+KTS/KPmJ5DlKxpUqPir/X8=; h=Subject:To:References:From:Date:In-Reply-To:From:Subject; b=m0UIl5rRKq/lfIqREl/pxKS2eeh+2y7OkJyAFRXK6Lm2NHxWeV1hqwxEVeu4PGtx6CAxV+WVp0w8UrFTVYQS3MjkdhJXXG4lLoSjZhTWCCAeGXtjwbLU29PQV8mlMZDD7bq3r18EYRDfKLhp7XG+KsJqPtMbBfXHY1vb51miloQUmpy+PGDyeSc4rCN8mDpSK2J29Yg3gdLMf0cXrio934BcgOKyyEaGGXuSOtZQakmQs4bUzhSe42K+WuoSCvu5rEAgwp2ECuiYfM7uyJqIl82gCv3JAdAn5tI0x26JM7CmIjO4ZCRdf4Of3G6bD5BLBaDcstljIaf2wTsn4sV+Sw== Received: from [98.139.214.32] by nm2.bullet.mail.bf1.yahoo.com with NNFMP; 14 Jan 2016 21:46:12 -0000 Received: from [68.142.230.71] by tm15.bullet.mail.bf1.yahoo.com with NNFMP; 14 Jan 2016 21:46:12 -0000 Received: from [127.0.0.1] by smtp228.mail.bf1.yahoo.com with NNFMP; 14 Jan 2016 21:46:12 -0000 X-Yahoo-Newman-Id: 358251.63705.bm@smtp228.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: ZT2wjJQVM1kkDgpyXCXkq5a3_KBNgyyeaMxg1zSaDiUk1SV lrW7G4fDRj9mXZI7GDaXawpb.LmpGq.q0aZhJroj1KBSFl1g2pZcDHjPR_ck 16WqkY1QuAv9n3GuwH.Kvgzm1alM1gM.vPMoXT8Qx.76.Y9NIQqcY_L0hg2X wH3Ag6Or4snmBxsIvqE9cpMWcNe6mpZAI6PeyQbKaCS0HGn_00Vs3evco7yO cJ1pbrqqO3WrukFqwEWz2WhW07czANbPQ6AhAoYAF7zphDnn8p.9Mcx9k2rV fQGBIGOYS3neI7EBVxwDcyEH1mAojAVZSgYAxdsvTfLmNC9rvlbVzCKff2Yc WuZ8MEyc404a2osr9k7I.U9yTA6s77T.R.rq4DT26b0.sMAxEK_qDZIdN0r4 9vjR8w5s215nBfph88lbrKNlMoWhWoYVYnKyidm9rq6yYCNeeEK6EymgLMyv qPLFETfzgvY.dNp__Y4R0zSTwLJzQOloIMpkv2L_s6p0o7fyD1HysFIYxjn3 PoPJUVuSX2XmqP3_RW0vcjMudVkrGr199 X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r294029 - in head/sys/boot/efi: . boot1 loader To: Steven Hartland , Nathan Whitehorn , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201601141853.u0EIrshB007863@repo.freebsd.org> <56980BAE.6070304@freebsd.org> <569812A6.9020101@freebsd.org> From: Pedro Giffuni Message-ID: <5698172E.6040107@FreeBSD.org> Date: Thu, 14 Jan 2016 16:46:22 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <569812A6.9020101@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 21:46:15 -0000 El 14/01/2016 a las 16:27, Steven Hartland escribió: > > > On 14/01/2016 20:57, Nathan Whitehorn wrote: >> >> >> On 01/14/16 10:53, Steven Hartland wrote: >>> Author: smh >>> Date: Thu Jan 14 18:53:54 2016 >>> New Revision: 294029 >>> URL: https://svnweb.freebsd.org/changeset/base/294029 >>> >>> Log: >>> Only build EFI components on supported compilers >>> As the in-tree GCC does not support __attribute__((ms_abi)) >>> EFI can only >>> be built with Clang. >>> The EFI loader and boot1 validated this, but unused libefi was >>> still built >>> causing issues under GCC after warnings where enabled by r293724. >>> Disable building all of EFI when the selected compiler is GCC. >> >> How about with newer-than-4.2 versions of GCC? Surely this *is* >> supported in newer compilers. Do we need some build infrastructure to >> how about the compiler version as well as type? >> -Nathan > > If it is then even without this change you wouldn't have have got the > EFI loader or boot1, just an unused libefi. > > This change ensures that builds with in-tree Clang and GCC build on > all platforms, even if GCC doesn't build the EFI components. > > If someone that uses none in-tree GCC has some time to dedicate to > make this work that would be great :) > Specially since the gcc-4.2 compiler will be axed mercilessly before 11.0-RELEASE. Pedro.