From nobody Fri Jul 25 22:25:16 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bpj9n08FVz62Qwj; Fri, 25 Jul 2025 22:25:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bpj9m5VsLz4F89; Fri, 25 Jul 2025 22:25:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753482316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gAXrUZmktzOaCgY/GCxBR9FX3NyOBe01V0UDacwRZz0=; b=rgso+fJomLflzbS2Mn68B3OpBl+b0WfV2ASQlWQn+xUXhS8uBcFSOTGC7esddab1mDkokp E2hVp0HAIjjU5ZawU584ce/d82CuE36dki8BOhcj1z6Zq/D16CXLfo2sZnBnt/Kv2jTeHJ wTjhFpC19z8cLZ4IiOmevK2NKqHOGxX9aLuaFg7EKP+t3tKRejtNiv8qqnkfB1xEUAaR8g IKeN0604POTjGozCHOILXeNE4PmRkOHUceo4xWvQBBwu8+0ShINdLJVc0figJs+NcyKRI3 bzbHeWzsgiQsKKG9DuHhIqu9b94z1GuE9XG3WBRJ2PIB1yMx/AAU6EEOJa/5vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753482316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gAXrUZmktzOaCgY/GCxBR9FX3NyOBe01V0UDacwRZz0=; b=qKRDW+0hTdBVwRPAGMznjwyBQLZ6yGQ0oKpQskQ3s983a8Dd5t6JEpjDwsrAJcIVCDzwiQ 6WtkUOkAQuoZW7w1SqUBhco5g2Sz+FUH4/7V9MzC9mUzwktoNZ+9sd+rjmpNcxBJJx31hs 2wtwfzwa6RZXy4Hhe/IJOZ1IOgvj0pnKi0mltNhRoE9t2rm3MthJ+umymgobG6Zu/9N6OD IuuB/LfVrnQiCvXRmD/Xq3MzR+kXeJNf5XzW8AXMCPy4pKFswbGtxBOkNqMI76xyrWxV98 KPn8OWl/5a85MMY2y/hCrdQjKJIISoWsdG5aDK/e2V5G6s41iR0Hx9Yinbf7pg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753482316; a=rsa-sha256; cv=none; b=KHvgNOX4KtyfzSmBRg7uxRVee7DAcH9Ne2UocjtWd+RsAD+Mkr1Vz9DKOgRg2ogyLDLSqR d7F/D5voAeIdTIxwx5K3w7PlLMCp4etQy6N7nHp4VN9PNjuewpMQbQJYmDIMkKdPef/QFV ZzwCeYAH2i4hgoov8INNEeCdsWLLdfwmuibNSLJjFdGw28dBnua0yoRZbTCMN59YNigwrM /D78HB28VneiyNVvIv2Gm6bXiLLNgUbLnTTBII46WsRzRuppOp3ObMt48x/T2QjZhwWIqm NxmyCkKrr/IP3YuYGB6RxXHfegHENu/5FEEF2QMaav7+JyNXpqz5NnmKHri4wQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bpj9m4Mg2z12qs; Fri, 25 Jul 2025 22:25:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56PMPGax058946; Fri, 25 Jul 2025 22:25:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56PMPGlf058943; Fri, 25 Jul 2025 22:25:16 GMT (envelope-from git) Date: Fri, 25 Jul 2025 22:25:16 GMT Message-Id: <202507252225.56PMPGlf058943@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 015ae6688993 - main - github: Update with better guidance on what's acceptable for src List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 015ae668899383ebf7969863dae1b45e169bbcdc Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=015ae668899383ebf7969863dae1b45e169bbcdc commit 015ae668899383ebf7969863dae1b45e169bbcdc Author: Warner Losh AuthorDate: 2025-07-25 22:24:34 +0000 Commit: Warner Losh CommitDate: 2025-07-25 22:24:34 +0000 github: Update with better guidance on what's acceptable for src Tighten and clarify the submission requirements: * No AI submissions * No trivial submissions: pull requests have to solve a real problem * We may timeout requests after a month * FreeBSD committers (all repos) are responible for merging their commits to the appropriate repo. github can be used to seek approval for such commits (eg a ports committer wants to make a src change). * Wordsmith a few things to make them clearer to people new to our jargon. * Not all psuedonyms are created equal, and we may disallow a PR based on that. Sponsored by: Netflix Feedback from: emaste Differential Revision: https://reviews.freebsd.org/D51538 --- CONTRIBUTING.md | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8e79652a09d2..02d718ef8018 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -33,9 +33,10 @@ and need discussion, or changes that require specialized review. A pull request will be considered if: +* The request is substantive in nature. We generally don't accept minor or cosmetic changes unless they are part of larger work in that area. Pull requests should solve a real, actual problem. * It is ready or nearly ready to be committed. A committer should be able to land the pull request with less than 10 minutes of additional work. * It passes all the GitHub CI jobs. -* You can respond to feedback quickly. +* You can respond to feedback quickly. If feedback is requested and one month passes without a response we may close the pull request. * It touches fewer than about 10 files and the changes are less than about 200 lines. Changes larger than this may be OK, or you may be asked to submit multiple pull requests of a more manageable size. * Each logical change is a separate commit within the pull request. Commit messages for each change should follow the [commit log message guide](https://docs.freebsd.org/en/articles/committers-guide/#commit-log-message). * All commits have, as the author, your name and valid email address as you would like to see them in the FreeBSD repository. Fake github.com addresses cannot be used. @@ -43,11 +44,14 @@ A pull request will be considered if: * Fixup commits should be squashed with the commit they are fixing. Each commit in your branch should be suitable for FreeBSD's repository. * Commits should include one or more `Signed-off-by:` lines with full name and email address certifying [Developer Certificate of Origin](https://developercertificate.org/). * The commits follow FreeBSD's style guide. See [Style](#Style). -* Run tools/build/checkstyle9.pl on your Git branch and eliminate all errors. +* Run tools/build/checkstyle9.pl on your Git branch and eliminate all errors, or provide an explanation for exceptions. * The commits do not introduce trailing white space. -* If the commit fixes a bug, please add 'PR: \' to the commit message. -* If there's a code review in Phabricator, please include a link as a 'Differential Revision: ' line. +* If the commit fixes a bug, please add 'PR: \' to the commit message to document the Bugzilla Problem Report number. +* If there's a code review related to this change, please include its URL in the commit message. However, where possible, please do not open both a differential review and a GitHub pull request. * If you have run FreeBSD's sources through a static analysis tool, please don't submit the raw results. Please also see the chunking up guidelines. Also, please make sure that kyua tests are the same before / after your change. Ideally, you'd also create a test case that shows an actual bug that's being fixed by these changes. +* FreeBSD committers submitting pull requests are responsible for pushing them into the tree (possibly with approval if cross-repo commit bit policy needs it). Pull requests by FreeBSD committers will be closed after a month unless there's a very good reason not to. +* Submissions using generative AI will be rejected. +* Submissions from AI chatbots will result in the account being banned. When updating your pull request, please rebase with a forced push rather than a merge commit. @@ -70,7 +74,8 @@ so. While the project strives to have a uniform coding style, our style offers a range of choices making some 'cleanups' ambiguous at best. Also, some files have their own consistent style that deviates from style(9). Style changes take volunteer time to process, but that time can be quite limited, so please be -respectful. +respectful. Trivial spelling changes should generally not be made in isolation +as they usually add little value, but do take up valuable volunteer time. The current theory for pull requests on GitHub is to facilitate inclusion in the project. The guidelines are streamlined for quick decisions about each pull @@ -90,7 +95,8 @@ closing it. We require that contributions are associated with a unique identity. The author email address should not be `@users.noreply.github.com`. Do note that your name and email address will become a permanent and immutable -part of the public Git history of the FreeBSD source tree. +part of the public Git history of the FreeBSD source tree. Authors that use +pseudonyms will be considered on a case by case basis. ## Style @@ -128,7 +134,7 @@ not present in FreeBSD's [shell](https://man.freebsd.org/cgi/man.cgi?query=sh&se ## Signed-off-by -Other projects use Signed-off-by to create a paper trail for contributions they +Other projects mandate Signed-off-by to create a paper trail for contributions they receive. The Developer Certificate of Origin is an attestation that the person making the contribution can do it under the current license of the file. Other projects that have 'delegated' hierarchies also use it when maintainers