From owner-freebsd-acpi@FreeBSD.ORG Thu Nov 25 01:25:06 2004 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A90D16A4CE; Thu, 25 Nov 2004 01:25:05 +0000 (GMT) Received: from ylpvm01.prodigy.net (ylpvm01-ext.prodigy.net [207.115.57.32]) by mx1.FreeBSD.org (Postfix) with ESMTP id E453343D49; Thu, 25 Nov 2004 01:25:04 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.5.50] (adsl-64-171-186-185.dsl.snfc21.pacbell.net [64.171.186.185])iAP1OwFt011571; Wed, 24 Nov 2004 20:24:58 -0500 Message-ID: <41A5346A.8070607@root.org> Date: Wed, 24 Nov 2004 17:24:58 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.3 (X11/20040901) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Oberman References: <20041124232339.E1B605D07@ptavv.es.net> In-Reply-To: <20041124232339.E1B605D07@ptavv.es.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: acpi@FreeBSD.org Subject: Re: PATCH: power down acpi and pci devices in suspend/resume X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Nov 2004 01:25:06 -0000 Kevin Oberman wrote: >>From: Nate Lawson >>Kevin Oberman wrote: >> >>>I have tried the new set of ACPI power patches and they are better. Now >>>the system almost works after resume. Only the cbb fails: >>>cbb0: bad Vcc request. ctrl=0xffffff88, status=0xffffffff >>>cbb_power: 0V >>>tdkphy0: detached >> >>Apologies, I just found what was causing this. My patch to perform >>suspending before powering down devices didn't get merged with this tree >>where I was implementing powerstates. I fixed this and unified pci/acpi >>power on suspend behavior under the tunable/sysctl "debug.suspend_power". >> >>Please test the attached patch. If it works well, I'll commit it as >>shown to get testing in -current. If it causes trouble, the default for >>debug.suspend_power can be set to 0. > > The new patch removed the annoying "bad Vcc request" messages, but > that's all it improved. With the new patch I still lose cbb1 and > anything connected to it. I see no real difference in the log other than > the disappearance of the Vcc messages, but that is a good thing. > > If I set debug.suspend_power to '0', everything works as it did > before. All PCI and CardBus devices seem to work fine after resume. I have a hypothesis that your PCI-Cardbus bridge is losing its configuration on being set to D3. Mine happens to retain it, hence it working fine. The solution is to restore bridge device config registers (non-type 0) in pci_cfg_save/restore(). I'll check with Warner to see if he's working on that, if not, I may. -Nate