From owner-cvs-all Sun Dec 26 4:28:31 1999 Delivered-To: cvs-all@freebsd.org Received: from overcee.netplex.com.au (overcee.netplex.com.au [202.12.86.7]) by hub.freebsd.org (Postfix) with ESMTP id A8BFF14C08; Sun, 26 Dec 1999 04:28:16 -0800 (PST) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id 26BD01CA0; Sun, 26 Dec 1999 20:28:09 +0800 (WST) (envelope-from peter@netplex.com.au) X-Mailer: exmh version 2.1.1 10/15/1999 To: "Daniel C. Sobral" Cc: Marcel Moolenaar , Bruce Evans , Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 In-Reply-To: Message from "Daniel C. Sobral" of "Sun, 26 Dec 1999 21:08:03 +0900." <38660523.74C8B37@newsguy.com> Date: Sun, 26 Dec 1999 20:28:09 +0800 From: Peter Wemm Message-Id: <19991226122809.26BD01CA0@overcee.netplex.com.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk "Daniel C. Sobral" wrote: > Peter Wemm wrote: > > > > > That is not true. Just try making a file without -C containing a > > > "comment" and then fortune'ing it. > > > > No problem, RELENG_2_2's strfile and fortune, *with* the ignore-comments pa tch > > but without -C: > > [example failing to show the difference in a fortune *containing* a > comment skipped] > > > -C is just a build inconvenience to make %% parsing optional. We have > > enough options already without adding them for things that don't make sense > > to be an option. > > -C is an option setting a flag in the dat file telling fortune to ignore > a specific type of line. Having it unconditional will make us > incompatible with other fortunes out there. But this is *our* internal utility for making a fortune.dat for *our* fortune(1). %% is nonsense to other fortunes.. Requiring -C makes us more incompatable than recognizing the comment unconditionally - it means we don't recognize our own files by default with standard options. > > ie: it still works. Even if it didn't, we don't need -C at 'make world' > > time because strfile does nothing special with the %% lines, and a new > > fortune(1) is installed at exactly the same time as the new datfiles. > > -C makes something special with the files created by strfile. Setting a > flag. > > Well, whatever. I think making it unconditional is an error, but I won't > make a bike shed out of it. I disagree. It is an error to make something difficult for no reason. Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message