From owner-svn-src-head@FreeBSD.ORG  Mon Jan  9 13:48:28 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CCE061065672;
	Mon,  9 Jan 2012 13:48:28 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id A25378FC18;
	Mon,  9 Jan 2012 13:48:28 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
	by cyrus.watson.org (Postfix) with ESMTPSA id 5B42846B5C;
	Mon,  9 Jan 2012 08:48:28 -0500 (EST)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id C526FB99B;
	Mon,  9 Jan 2012 08:48:27 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Pawel Jakub Dawidek <pjd@freebsd.org>
Date: Mon, 9 Jan 2012 08:15:44 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; )
References: <201201080055.q080tMlJ063808@svn.freebsd.org>
	<20120108104330.GC1674@garage.freebsd.pl>
In-Reply-To: <20120108104330.GC1674@garage.freebsd.pl>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201201090815.44495.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Mon, 09 Jan 2012 08:48:27 -0500 (EST)
Cc: svn-src-head@freebsd.org, Adrian Chadd <adrian@freebsd.org>,
	src-committers@freebsd.org, svn-src-all@freebsd.org
Subject: Re: svn commit: r229800 - head/sys/conf
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jan 2012 13:48:28 -0000

On Sunday, January 08, 2012 5:43:30 am Pawel Jakub Dawidek wrote:
> On Sun, Jan 08, 2012 at 12:55:22AM +0000, Adrian Chadd wrote:
> > Author: adrian
> > Date: Sun Jan  8 00:55:22 2012
> > New Revision: 229800
> > URL: http://svn.freebsd.org/changeset/base/229800
> > 
> > Log:
> >   Make these two files conditionally build on UFS_ACL, as it doesn't
> >   seem to be used elsewhere.
> >   
> >   Since UFS_ACL is enabled by default for GENERIC kernels, this shouldn't
> >   break anything - but please beat me to fix things if it does.
> 
> If someone is actually using GENERIC kernel. This change will break all
> my system next time I upgrade. Adding UFS_ACL option to the kernel
> config to make ZFS kernel module to work doesn't sound very intuitive.
> 
> I understand what you are trying to accomplish, but we really need to
> find better way to do this. Until then, could you back it out?

Why not make 'options ZFS' work?  Then you can have subr_acl_nfs.c depend on
ZFS as well.

-- 
John Baldwin