From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Apr 12 17:40:01 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EAC43D7E for ; Sat, 12 Apr 2014 17:40:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C737E1CB9 for ; Sat, 12 Apr 2014 17:40:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s3CHe05Q039870 for ; Sat, 12 Apr 2014 17:40:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s3CHe0oF039865; Sat, 12 Apr 2014 17:40:00 GMT (envelope-from gnats) Resent-Date: Sat, 12 Apr 2014 17:40:00 GMT Resent-Message-Id: <201404121740.s3CHe0oF039865@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andrey Zholos Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E4915C4F for ; Sat, 12 Apr 2014 17:34:26 +0000 (UTC) Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D0CA71C98 for ; Sat, 12 Apr 2014 17:34:26 +0000 (UTC) Received: from cgiserv.freebsd.org ([127.0.1.6]) by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s3CHYPtY060758 for ; Sat, 12 Apr 2014 17:34:25 GMT (envelope-from nobody@cgiserv.freebsd.org) Received: (from nobody@localhost) by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s3CHYPeC060751; Sat, 12 Apr 2014 17:34:25 GMT (envelope-from nobody) Message-Id: <201404121734.s3CHYPeC060751@cgiserv.freebsd.org> Date: Sat, 12 Apr 2014 17:34:25 GMT From: Andrey Zholos To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/188524: sysutils/grub2 and ZFS: missing feature for read 'com.delphix:hole_birth' X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Apr 2014 17:40:01 -0000 >Number: 188524 >Category: ports >Synopsis: sysutils/grub2 and ZFS: missing feature for read 'com.delphix:hole_birth' >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Apr 12 17:40:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Andrey Zholos >Release: 10.0-STABLE >Organization: >Environment: >Description: I am using GRUB to boot the kernel directly from ZFS. After running zpool upgrade -a recently, GRUB stopped being able to access the ZFS filesystem. >How-To-Repeat: # grub-probe -d /dev/gpt/mypool missing feature for read 'com.delphix:hole_birth' missing feature for read 'com.delphix:hole_birth' missing feature for read 'com.delphix:hole_birth' missing feature for read 'com.delphix:hole_birth' grub-probe: error: unknown filesystem. >Fix: Patch to ignore this feature flag attached. # grub-probe -d /dev/gpt/mypool zfs Booting with GRUB also works so far. However, I'm not certain whether the ZFS reading code in GRUB actually needs to be updated for this feature flag. Patch attached with submission follows: --- sysutils/grub2/files/patch-grub-2.00-zfs-feature-flag-support +++ sysutils/grub2/files/patch-grub-2.00-zfs-feature-flag-support @@ -92,7 +92,7 @@ + * to be listed here since grub opens pools in read-only mode. + */ +static const char *spa_feature_names[] = { -+ "org.illumos:lz4_compress",NULL ++ "org.illumos:lz4_compress","com.delphix:hole_birth",NULL +}; + +static int NESTED_FUNC_ATTR >Release-Note: >Audit-Trail: >Unformatted: