From owner-svn-src-all@FreeBSD.ORG  Sat Feb 15 17:23:51 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 916D684A;
 Sat, 15 Feb 2014 17:23:51 +0000 (UTC)
Received: from mail107.syd.optusnet.com.au (mail107.syd.optusnet.com.au
 [211.29.132.53])
 by mx1.freebsd.org (Postfix) with ESMTP id 7A8281910;
 Sat, 15 Feb 2014 17:23:50 +0000 (UTC)
Received: from c122-106-144-87.carlnfd1.nsw.optusnet.com.au
 (c122-106-144-87.carlnfd1.nsw.optusnet.com.au [122.106.144.87])
 by mail107.syd.optusnet.com.au (Postfix) with ESMTPS id 29492D4353F;
 Sun, 16 Feb 2014 04:03:43 +1100 (EST)
Date: Sun, 16 Feb 2014 04:02:32 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Dimitry Andric <dim@FreeBSD.org>
Subject: Re: svn commit: r261916 - head/sys/dev/xen/console
In-Reply-To: <201402151237.s1FCbRnh000507@svn.freebsd.org>
Message-ID: <20140216035823.I2978@besplex.bde.org>
References: <201402151237.s1FCbRnh000507@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.1 cv=HZAtEE08 c=1 sm=1 tr=0
 a=p/w0leo876FR0WNmYI1KeA==:117 a=PO7r1zJSAAAA:8 a=3iJA4HwJju4A:10
 a=kj9zAlcOel0A:10 a=JzwRw_2MAAAA:8 a=FBIJrv5t4GUA:10
 a=jGUZrl8DfiWc276YmdAA:9 a=CjuIK1q_8ugA:10
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Feb 2014 17:23:51 -0000

On Sat, 15 Feb 2014, Dimitry Andric wrote:

> Log:
>  In sys/dev/xen/console/console.c, #if 0 an unused static function.
>
>  MFC after:	3 days
>
> Modified:
>  head/sys/dev/xen/console/console.c
>
> Modified: head/sys/dev/xen/console/console.c
> ==============================================================================
> --- head/sys/dev/xen/console/console.c	Sat Feb 15 12:25:01 2014	(r261915)
> +++ head/sys/dev/xen/console/console.c	Sat Feb 15 12:37:26 2014	(r261916)
> @@ -356,6 +356,7 @@ xcclose(struct tty *tp)
> 	xen_console_up = 0;
> }
>
> +#if 0
> static inline int
> __xencons_put_char(int ch)
> {
> @@ -365,6 +366,7 @@ __xencons_put_char(int ch)
> 	wbuf[WBUF_MASK(wp++)] = _ch;
> 	return 1;
> }
> +#endif
>
> static void

Why?  There are hundreds if not thousands of static inline functions in
headers, and most of these functions are not always used, so there would
be [hundreds if not thousands] * [number of #includes] compiler warnings
if compilers warned about things like this.  They could handle include
files specially, but shouldn't.

Bruce