From owner-svn-src-head@FreeBSD.ORG Sat Mar 24 19:36:37 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 191A7106564A for ; Sat, 24 Mar 2012 19:36:37 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm19-vm0.bullet.mail.ne1.yahoo.com (nm19-vm0.bullet.mail.ne1.yahoo.com [98.138.91.59]) by mx1.freebsd.org (Postfix) with SMTP id A04328FC1A for ; Sat, 24 Mar 2012 19:36:36 +0000 (UTC) Received: from [98.138.90.56] by nm19.bullet.mail.ne1.yahoo.com with NNFMP; 24 Mar 2012 19:30:50 -0000 Received: from [98.138.84.40] by tm9.bullet.mail.ne1.yahoo.com with NNFMP; 24 Mar 2012 19:30:50 -0000 Received: from [127.0.0.1] by smtp108.mail.ne1.yahoo.com with NNFMP; 24 Mar 2012 19:30:50 -0000 X-Yahoo-Newman-Id: 19267.64437.bm@smtp108.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: NCYM8lcVM1mHXNXU64sK1jzbvZgWFuEaw19oLMzgVhzbPMv slFZ92MF2Rj9cWcf4G8K_eS8vU1VynQCaZ0G0eeWP1mJDXeyjxrlR.17EZUJ o9f1MeXhALuC4TlACDNV773tcpa1fY6.pohc.Gqs2fDVqzgTVgPnocGarv_s 3wFCvrQi2lZFaiLriw40cab3mWj2eZ0dQXocxsxhS2OuSlt1hgvdFbscRC9Y SQVr0I6jmTkFZgG3vas30smAbjgGWUmG8s2MXWbg9.MMwgt5Z6.Eb._yXnNd QSGlq3XZXeCEnysQ9.DGe6nrsRn.mTKZyu5FPxqwqVbdRkY7GIYxQ7Z7tMpA YPAXY_yyEX8b.xnqM.N2W2Fd_tRJk9b4H23fTbw4VtkwMJimOvE2MIfaWJVy g9wJZ4zT1fnjxE1tO7s7UdbW6RgabWI2P3lYLsrOKf7A06Qj_EZAjvvNixps jyYKzDe1L_ElAOW.gj_96nfZcC.HEgueqL01Az1NKsTt8hLxqBvAjAik0XXA UhF4IuCFaB.OXlx0pCDbR1_PttZlNqSNG8mJ1qYWtlVG215eDXOzD5.E0N4r YPKLF872fRYLVSA-- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Received: from [192.168.10.102] (pfg@200.118.157.7 with plain) by smtp108.mail.ne1.yahoo.com with SMTP; 24 Mar 2012 12:30:49 -0700 PDT Message-ID: <4F6E20E7.8040206@FreeBSD.org> Date: Sat, 24 Mar 2012 14:30:47 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:10.0.2) Gecko/20120226 Thunderbird/10.0.2 MIME-Version: 1.0 To: David Chisnall References: <201203232010.q2NKAuIE092217@svn.freebsd.org> In-Reply-To: <201203232010.q2NKAuIE092217@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r233391 - head/contrib/libstdc++/libsupc++ X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Mar 2012 19:36:37 -0000 Ahem.. On 03/23/12 15:10, David Chisnall wrote: > Author: theraven > Date: Fri Mar 23 20:10:56 2012 > New Revision: 233391 > URL: http://svn.freebsd.org/changeset/base/233391 > > Log: > Revert ABI breakage in libsupc++. > > Unfortunately, the ABI was broken upstream for the 4.2 release, which we > imported. We then shipped the broken version for several years and certain > ports (e.g. libobjc2) depend on it, so we're stuck with it for now... > > We should revisit this for 10.0, since we're allowed to break the ABI then, but > until then we should keep the ABI we shipped with 8.x and 9.x. > > Reviewed by: kan > Approved by: dim (mentor) > MFC after: 1 week > > Modified: > head/contrib/libstdc++/libsupc++/typeinfo > > Let me try to recap: gcc-4.2.1 broke the ABI and we shipped it for a long time. The bug was detected by Apple and others: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35081 It was fixed for gcc-4.2.2 (which we didn't ship): http://gcc.gnu.org/viewcvs?view=revision&revision=129061 I inadvertently fixed the bug 3 months ago when I brought in the last LGPLv2 updates for libstdc++: http://svnweb.freebsd.org/base?view=revision&revision=228780 The fix hasn't been shipped but was MFC'd and is actually in 8.3-RC* !! David's commit actually restores the gcc 4.2.1 bug (?). Pedro.